Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for tidb-binlog/pump_client pkg #33463

Closed
Tracked by #26022
tisonkun opened this issue Mar 25, 2022 · 3 comments · Fixed by #33475
Closed
Tracked by #26022

migrate test-infra to testify for tidb-binlog/pump_client pkg #33463

tisonkun opened this issue Mar 25, 2022 · 3 comments · Fixed by #33475
Assignees
@zanpocc
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Mar 25, 2022
Closed
53 tasks
@tisonkun tisonkun added type/enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 25, 2022
@zanpocc
Copy link
Contributor

zanpocc commented Mar 26, 2022

let me try

@tisonkun
Copy link
Contributor Author

@zanpocc thanks for your attempt. I'll assign you and you can assign yourself the next time.

/assign @zanpocc

@zanpocc zanpocc mentioned this issue Mar 26, 2022
Merged
12 tasks
@zanpocc
Copy link
Contributor

zanpocc commented Mar 26, 2022

@zanpocc thanks for your attempt. I'll assign you and you can assign yourself the next time.

/assign @zanpocc

oh thanks
I'm new to tidb and I just submitted a pull request for this issue, maybe you can give me some advice for me :)

zanpocc added a commit to zanpocc/tidb that referenced this issue Mar 26, 2022
@zanpocc
tidb-binlog/pump_client: migrate test-infra to testify (pingcap#33475)
fe2b7f9 
close pingcap#33463
ti-chi-bot pushed a commit that referenced this issue Mar 27, 2022
@zanpocc
tidb-binlog/pump_client: migrate test-infra to testify (#33475)
e09bc29 
close #33463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanpocc zanpocc

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tidb-binlog/pump_client: migrate test-infra to testify zanpocc/tidb
2 participants
@tisonkun @zanpocc