A panic occurs when tidb_enable_ordered_result_mode is enabled

[Bowen-Tang]

Bug Report

开启 tidb_enable_ordered_result_mode 后，SQL 执行 panic

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

执行正常

3. What did you see instead (Required)

[2023/06/25 10:18:28.572 +08:00] [ERROR] [conn.go:1072] ["connection running loop panic"] [conn=8396308395326069831] [lastSQL="SELECT p.product_code \r\nFROM shop_upload_commodity_pic p\r\nGROUP BY p.product_code \r\nHAVING count(*)>1 \r\nORDER BY p.product_code \r\nlimit 10"] [err="runtime error: invalid memory address or nil pointer dereference"] [stack="github.com/pingcap/tidb/server.(*clientConn).Run.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/server/conn.go:1075\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:884\ngit.luolix.top/pingcap/tidb/executor.(*Compiler).Compile.func1\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/executor/compiler.go:54\nruntime.gopanic\n\t/usr/local/go/src/runtime/panic.go:884\nruntime.panicmem\n\t/usr/local/go/src/runtime/panic.go:260\nruntime.sigpanic\n\t/usr/local/go/src/runtime/signal_unix.go:837\ngit.luolix.top/pingcap/tidb/expression.(*Schema).ColumnIndex\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/expression/schema.go:133\ngit.luolix.top/pingcap/tidb/expression.(*Schema).Contains\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/expression/schema.go:151\ngit.luolix.top/pingcap/tidb/planner/core.(*resultReorder).extractHandleCol\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/rule_result_reorder.go:109\ngit.luolix.top/pingcap/tidb/planner/core.(*resultReorder).completeSort\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/rule_result_reorder.go:55\ngit.luolix.top/pingcap/tidb/planner/core.(*resultReorder).completeSort\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/rule_result_reorder.go:52\ngit.luolix.top/pingcap/tidb/planner/core.(*resultReorder).completeSort\n\t/home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/planner/core/rule_result_reorder.go:52\ngit.luolix.top/pingcap/tidb/planner/core.(*resultReorder).optimize\n\t/

4. What is your TiDB version? (Required)

tidb 7.1

[XuHuaiyu]

Panic happened during optimizing. I'd like to change the label to sig/planner

[chrysan]

@Bowen-Tang Can you provide detailed reproduce steps?

[guo-shaoge]

@Bowen-Tang Can you provide detailed reproduce steps?

set tidb_enable_ordered_result_mode = on;
create table t1(c1 int);
explain select * from t1 group by t1.c1 having count(1) > 1 order by count(1) limit 10;

MySQL [test]> select tidb_version();
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                                 |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v7.1.0
Edition: Community
Git Commit Hash: 635a4362235e8a3c0043542e629532e3c7bb2756
Git Branch: HEAD
UTC Build Time: 2023-07-03 02:30:01
GoVersion: go1.20.1
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.001 sec)

MySQL [test]> set tidb_enable_ordered_result_mode = on;
Query OK, 0 rows affected (0.001 sec)

MySQL [test]> explain select * from t1 group by t1.c1 having count(1) > 1 order by count(1) limit 10;
ERROR 1105 (HY000): runtime error: invalid memory address or nil pointer dereference

stack

github.com/pingcap/tidb/expression.(*Schema).ColumnIndex
    /home/guojiangtao/work/tidb/expression/schema.go:133
github.com/pingcap/tidb/expression.(*Schema).Contains
    /home/guojiangtao/work/tidb/expression/schema.go:151
github.com/pingcap/tidb/planner/core.(*resultReorder).extractHandleCol
    /home/guojiangtao/work/tidb/planner/core/rule_result_reorder.go:109
github.com/pingcap/tidb/planner/core.(*resultReorder).completeSort
    /home/guojiangtao/work/tidb/planner/core/rule_result_reorder.go:55
github.com/pingcap/tidb/planner/core.(*resultReorder).completeSort
    /home/guojiangtao/work/tidb/planner/core/rule_result_reorder.go:52
github.com/pingcap/tidb/planner/core.(*resultReorder).completeSort
    /home/guojiangtao/work/tidb/planner/core/rule_result_reorder.go:52
github.com/pingcap/tidb/planner/core.(*resultReorder).optimize
    /home/guojiangtao/work/tidb/planner/core/rule_result_reorder.go:43
github.com/pingcap/tidb/planner/core.logicalOptimize
    /home/guojiangtao/work/tidb/planner/core/optimizer.go:1108
github.com/pingcap/tidb/planner/core.DoOptimize
    /home/guojiangtao/work/tidb/planner/core/optimizer.go:301
github.com/pingcap/tidb/planner.optimize
    /home/guojiangtao/work/tidb/planner/optimize.go:506
github.com/pingcap/tidb/planner.Optimize
    /home/guojiangtao/work/tidb/planner/optimize.go:329
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildExplain
    /home/guojiangtao/work/tidb/planner/core/planbuilder.go:5041
github.com/pingcap/tidb/planner/core.(*PlanBuilder).Build
    /home/guojiangtao/work/tidb/planner/core/planbuilder.go:794
github.com/pingcap/tidb/planner.buildLogicalPlan
    /home/guojiangtao/work/tidb/planner/optimize.go:550
github.com/pingcap/tidb/planner.optimize
    /home/guojiangtao/work/tidb/planner/optimize.go:471
github.com/pingcap/tidb/planner.Optimize
    /home/guojiangtao/work/tidb/planner/optimize.go:329
github.com/pingcap/tidb/executor.(*Compiler).Compile
    /home/guojiangtao/work/tidb/executor/compiler.go:98
github.com/pingcap/tidb/session.(*session).ExecuteStmt
    /home/guojiangtao/work/tidb/session/session.go:2177
github.com/pingcap/tidb/server.(*TiDBContext).ExecuteStmt
    /home/guojiangtao/work/tidb/server/driver_tidb.go:252
github.com/pingcap/tidb/server.(*clientConn).handleStmt

[guo-shaoge]

Seems (rs *resultReorder) extractHandleCol didn't handle other opetrators, like proj for this issue, so handleCol of lp's child is nil, and the logic didn't check if handleCol is nil or not, which makes this nil pointer error.