Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there are some memory leak in TTL's implement #45510

Closed
Tracked by #39262
lcwangchao opened this issue Jul 24, 2023 · 0 comments · Fixed by #45512
Closed
Tracked by #39262

there are some memory leak in TTL's implement #45510

lcwangchao opened this issue Jul 24, 2023 · 0 comments · Fixed by #45512
Labels
affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Jul 24, 2023

If you run tidb with a very long time with many TTL tables, you can seem some memory leak:

image

  1. dettachStatsCollector , see:

tidb/session/session.go

Lines 3660 to 3665 in 9e20208

func detachStatsCollector(s *session) *session {
s.statsCollector = nil
s.idxUsageCollector = nil
return s
}

it only sets two collectors to nil but did not call Delete for it.

  1. The context created here is not guaranteed to be cancelled finally:

ctx, cancel := context.WithCancel(m.ctx)
scanTask := &ttlScanTask{
ctx: ctx,
TTLTask: task,
tbl: table,
statistics: &ttlStatistics{},
}

@lcwangchao lcwangchao mentioned this issue Jul 24, 2023
60 tasks
@lcwangchao lcwangchao added type/bug The issue is confirmed as a bug. severity/major labels Jul 24, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jul 24, 2023
@lcwangchao lcwangchao added sig/sql-infra SIG: SQL Infra affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 and removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jul 24, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 24, 2023
ti-chi-bot bot pushed a commit that referenced this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant