Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move log restore delete_range back to ddl delete_range #47738

Closed
3 tasks done
Leavrth opened this issue Oct 18, 2023 · 0 comments · Fixed by #48050
Closed
3 tasks done

move log restore delete_range back to ddl delete_range #47738

Leavrth opened this issue Oct 18, 2023 · 0 comments · Fixed by #48050
Assignees
@Leavrth
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Leavrth
Copy link
Contributor

Leavrth commented Oct 18, 2023 •
edited
Loading

Enhancement

Currently we implement the same delete range logic as ddl's. But it's too expensive to keep in sync with ddl's delete range logic. Therefore, there is a plan to move it back.

  • fix the bugs and add integration test in release-6.5 and release-7.1 and release-7.5
  • update the new action in release-7.1 and release-7.5
  • combine these logic back into ddl in release-7.6.
@Leavrth Leavrth added type/enhancement The issue or PR belongs to an enhancement. component/br This issue is related to BR of TiDB. labels Oct 18, 2023
@Leavrth Leavrth self-assigned this Oct 18, 2023
@Leavrth Leavrth mentioned this issue Oct 18, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 23, 2023
@Leavrth
br: add integration test for pitr (#47740)
c21a5cf 
ref #47738
@Leavrth Leavrth added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Oct 23, 2023
This was referenced Oct 23, 2023
Merged
Merged
Merged
@Leavrth Leavrth mentioned this issue Oct 27, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2023
@ti-chi-bot
br: add integration test for pitr (#47740) (#47906)
df8d7c9 
ref #47738
ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2023
@ti-chi-bot
br: add integration test for pitr (#47740) (#47907)
77e8bd9 
ref #47738
ti-chi-bot bot pushed a commit that referenced this issue Nov 1, 2023
@ti-chi-bot
br: add integration test for pitr (#47740) (#47908)
92a3929 
ref #47738
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@Leavrth
ddl: wrap the sessionctx to public delete range logic to BR (#48050)
be62f75 
close #47738
This was referenced Dec 7, 2023
Closed
Closed
Closed
@Leavrth Leavrth mentioned this issue Mar 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leavrth Leavrth

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: wrap the sessionctx to public delete range logic to BR Leavrth/tidb
1 participant
@Leavrth