Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static calibrate resource should not depend on prometheus data #49174

Closed
glorv opened this issue Dec 5, 2023 · 0 comments · Fixed by #49176
Closed

static calibrate resource should not depend on prometheus data #49174

glorv opened this issue Dec 5, 2023 · 0 comments · Fixed by #49176
Labels
affects-7.1 affects-7.5 severity/major sig/execution SIG execution type/bug This issue is a bug.

Comments

@glorv
Copy link
Contributor

glorv commented Dec 5, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

deploy a tidb cluster with tiup playground --without-minitor and run:

mysql> calibrate resource;
ERROR 1105 (HY000): There is no CPU quota metrics, query metric error: [domain:9009]Prometheus address is not set in PD and etcd

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

nightly
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Dec 5, 2023
@glorv glorv mentioned this issue Dec 5, 2023
Merged
13 tasks
@glorv glorv removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Dec 5, 2023
@seiya-annie seiya-annie added the sig/execution SIG execution label Dec 5, 2023
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@glorv
resource_control: fetch cpu quota metrics from store instead of prome…
5db7c6a 
…theus (#49176)

close #49174
This was referenced Dec 7, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Dec 8, 2023
@ti-chi-bot
resource_control: fetch cpu quota metrics from store instead of prome…
b23937e 
…theus (#49176) (#49256)

close #49174
ti-chi-bot bot pushed a commit that referenced this issue Dec 8, 2023
@ti-chi-bot
resource_control: fetch cpu quota metrics from store instead of prome…
6c98485 
…theus (#49176) (#49255)

close #49174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 affects-7.5 severity/major sig/execution SIG execution type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource_control: fetch cpu quota metrics from store instead of prometheus glorv/tidb
2 participants
@glorv @seiya-annie