Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb crash because of logging grpc error #51301

Closed
guo-shaoge opened this issue Feb 26, 2024 · 1 comment · Fixed by #52179
Closed

tidb crash because of logging grpc error #51301

guo-shaoge opened this issue Feb 26, 2024 · 1 comment · Fixed by #52179
Assignees
@guo-shaoge
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 affects-7.6 severity/major sig/execution SIG execution type/bug This issue is a bug.

Comments

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 26, 2024 •
edited

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

tidb crash because of logging grpc err, check https://github.com/grpc/grpc-go/blob/v1.51.0/internal/status/status.go#L150, there is a related grpc issue: grpc/grpc-go#6204.

It's hard to reproduce, but we needs to figure out a way to fix it.
img_v3_028a_a5c0aba3-54e1-4509-a1dd-2695cbcd17bg

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

v6.5.7
@guo-shaoge guo-shaoge added the type/bug This issue is a bug. label Feb 26, 2024
@seiya-annie seiya-annie added the sig/execution SIG execution label Mar 5, 2024
@guo-shaoge guo-shaoge self-assigned this Mar 11, 2024
@guo-shaoge guo-shaoge mentioned this issue Mar 28, 2024
Merged
13 tasks
@guo-shaoge guo-shaoge added affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.6 affects-7.0 affects-7.1 and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 may-affects-7.5 labels Mar 28, 2024
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@guo-shaoge
pkg/util: fix panic caused by logging grpc err (#52179)
089cba4 
close #51301
This was referenced Mar 28, 2024
Merged
Merged
Merged
Merged
Open
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
pkg/util: fix panic caused by logging grpc err (#52179) (#52188)
504cc18 
close #51301
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
pkg/util: fix panic caused by logging grpc err (#52179) (#52185)
e1776e2 
close #51301
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
pkg/util: fix panic caused by logging grpc err (#52179) (#52186)
95a1400 
close #51301
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
pkg/util: fix panic caused by logging grpc err (#52179) (#52187)
69894ec 
close #51301
@YangKeao YangKeao mentioned this issue Apr 19, 2024
Closed
@YangKeao
Copy link
Member

@guo-shaoge We still didn't know the root cause, right? It seems that the PR catches and prints a log when it panics.

@lilin90 lilin90 mentioned this issue May 10, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guo-shaoge guo-shaoge

Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.2 affects-7.3 affects-7.4 affects-7.5 affects-7.6 severity/major sig/execution SIG execution type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/util: fix panic caused by logging grpc err guo-shaoge/tidb
5 participants
@YangKeao @guo-shaoge @aytrack @seiya-annie @ti-chi-bot