Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb config doesn't take effects when there are invalid config #51399

Closed
guo-shaoge opened this issue Feb 28, 2024 · 1 comment · Fixed by #51828
Closed

tidb config doesn't take effects when there are invalid config #51399

guo-shaoge opened this issue Feb 28, 2024 · 1 comment · Fixed by #51828
Assignees
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@guo-shaoge
Copy link
Collaborator

guo-shaoge commented Feb 28, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. write config like
  global:
    user: "guojiangtao"
    ssh_port: 22
    deploy_dir: "/home/guojiangtao/work/tiup_cluster/s3/data/deploy"
    data_dir: "/home/guojiangtao/work/tiup_cluster/s3/data/data"
    arch: "amd64"

  server_configs:
    tidb:
      mem-quota-query: 1073741824
      log.file.max-backups: 10
      log.file.max-days: 5
      log.slow-threshold: 1000
      disaggregated-tiflash: true
      new_collations_enabled_on_first_bootstrap: false
      oom-action: log
      performance.enforce-mpp: 1
      performance.txn-total-size-limit: 107374182
...
  1. tiup cluster setup new cluster
  2. check disaggregated-tiflash config: show config where name like '%disagg%'

2. What did you expect to see? (Required)

tidb config is correct

3. What did you see instead (Required)

disaggregated-tiflash config is wrong
ed8e4b65-0641-421e-b169-d883cd75ccd2

4. What is your TiDB version? (Required)

v7.5.0

@guo-shaoge guo-shaoge added the type/bug The issue is confirmed as a bug. label Feb 28, 2024
@guo-shaoge
Copy link
Collaborator Author

guo-shaoge commented Feb 28, 2024

Actually tidb should report error because perofrmance.enforce-mpp: 1 should be performance.enforce-mpp: true, but tidb miss checking return error of parsing config, code, which cause the config is default value

@seiya-annie seiya-annie added sig/sql-infra SIG: SQL Infra sig/execution SIG execution severity/major and removed sig/sql-infra SIG: SQL Infra labels Mar 5, 2024
@seiya-annie seiya-annie added sig/sql-infra SIG: SQL Infra and removed sig/execution SIG execution labels Mar 5, 2024
@Defined2014 Defined2014 self-assigned this Mar 15, 2024
@Defined2014 Defined2014 added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants