Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support div_precision_increment sysvar in tidb #51501

Closed
yibin87 opened this issue Mar 5, 2024 · 1 comment · Fixed by #51538
Closed

Support div_precision_increment sysvar in tidb #51501

yibin87 opened this issue Mar 5, 2024 · 1 comment · Fixed by #51538
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Mar 5, 2024

Enhancement

https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_div_precision_increment

“This variable indicates the number of digits by which to increase the scale of the result of division operations performed with the / operator. The default value is 4. The minimum and maximum values are 0 and 30, respectively. The following example illustrates the effect of increasing the default value.”

However in TiDB, this variable doesn't show the same behavior. In this FD, we shall make it compatible with MySQL, to satisfy the requirements of longer precision

@yibin87 yibin87 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 5, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Mar 5, 2024

/assign @yibin87

ti-chi-bot bot pushed a commit to tikv/tikv that referenced this issue Mar 13, 2024
…port in dag request (#16622)

close #16627, ref pingcap/tidb#51501

Add support for div_precision_increment in dag request.

Signed-off-by: yibin <huyibin@pingcap.com>
dbsid pushed a commit to dbsid/tikv that referenced this issue Mar 24, 2024
…port in dag request (tikv#16622)

close tikv#16627, ref pingcap/tidb#51501

Add support for div_precision_increment in dag request.

Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant