Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stores that have been pruned during the detection #52313

Closed
xzhangxian1008 opened this issue Apr 2, 2024 · 5 comments · Fixed by #52314
Closed

Remove stores that have been pruned during the detection #52313

xzhangxian1008 opened this issue Apr 2, 2024 · 5 comments · Fixed by #52314
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@xzhangxian1008
Copy link
Contributor

xzhangxian1008 commented Apr 2, 2024

Enhancement

Before sending mpp tasks, tidb will detect the liveness of tiflash nodes. However, tidb also detect nodes that have been pruned from the cluster. Once the detection of one tiflash node fails. The failed tiflash node will be added to a list to be periodically detected. If many tiflash nodes have been pruned before, the number of detection request will be very large and affects the network of production environment. So we need to detect nodes that are valid in the cluster.

@xzhangxian1008 xzhangxian1008 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 2, 2024
@xzhangxian1008 xzhangxian1008 changed the title Remove stores that have no region before balance Remove stores that have no regions before balance May 24, 2024
@xzhangxian1008 xzhangxian1008 changed the title Remove stores that have no regions before balance Remove stores that have been pruned during the detection May 24, 2024
@ti-chi-bot ti-chi-bot added affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. labels May 27, 2024
@jebter jebter added the sig/execution SIG execution label May 27, 2024
@xzhangxian1008
Copy link
Contributor Author

/type bug

@ti-chi-bot ti-chi-bot bot added the type/bug The issue is confirmed as a bug. label May 27, 2024
@xzhangxian1008
Copy link
Contributor Author

/remove-enchancement

@xzhangxian1008
Copy link
Contributor Author

/remove-type enchancement

Copy link

ti-chi-bot bot commented May 27, 2024

@xzhangxian1008: These labels are not set on the issue: type/enchancement.

In response to this:

/remove-type enchancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xzhangxian1008
Copy link
Contributor Author

/remove-type enhancement

@ti-chi-bot ti-chi-bot bot removed the type/enhancement The issue or PR belongs to an enhancement. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants