Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global sync load to avoid too much item in the channel #52797

Closed
hawkingrei opened this issue Apr 22, 2024 · 0 comments · Fixed by #52796
Closed

global sync load to avoid too much item in the channel #52797

hawkingrei opened this issue Apr 22, 2024 · 0 comments · Fixed by #52796
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Apr 22, 2024 •
edited
Loading

Enhancement

Now, we need to put all sync load items into the channel, then the workers will get them to sync load through the single flight. we should put all sync load items into a single flight. then worker will deal with them.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Apr 22, 2024
@hawkingrei hawkingrei mentioned this issue Apr 22, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 24, 2024
@hawkingrei
statistics: support global singleflight for sync load (#52796)
cd90f81 
close #52797
@ti-chi-bot ti-chi-bot mentioned this issue Apr 24, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Apr 24, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 24, 2024
@ti-chi-bot
statistics: support global singleflight for sync load (#52796) (#52870)
7b5af46 
close #52797
@jebter jebter added the sig/planner SIG: Planner label Apr 29, 2024
@hawkingrei hawkingrei mentioned this issue May 16, 2024
Open
@ti-chi-bot ti-chi-bot mentioned this issue May 16, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label May 17, 2024
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2024
@ti-chi-bot
statistics: support global singleflight for sync load (#52796) (#53340)
be578f5 
close #52797
This was referenced Jun 5, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jun 6, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jun 6, 2024
@ti-chi-bot
statistics: support global singleflight for sync load (#52796) (#53838)
739ff55 
close #52797
hawkingrei pushed a commit to hawkingrei/tidb that referenced this issue Jul 1, 2024
@ti-chi-bot @hawkingrei
statistics: support global singleflight for sync load (pingcap#52796) (…
9a8df94 
…pingcap#53838)

close pingcap#52797
@hawkingrei hawkingrei mentioned this issue Jul 1, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 28, 2024
@ti-chi-bot
statistics: support global singleflight for sync load (#52796) (#53839)
d140d7b 
close #52797
winoros pushed a commit to winoros/tidb that referenced this issue Aug 28, 2024
@ti-chi-bot @winoros
statistics: support global singleflight for sync load (pingcap#52796) (…
5a63849 
…pingcap#53839)

close pingcap#52797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: support global singleflight for sync load hawkingrei/tidb
3 participants
@hawkingrei @jebter @ti-chi-bot