Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestAddIndexFinishImportError is invalid #53641

Closed
D3Hunter opened this issue May 29, 2024 · 0 comments · Fixed by #53643
Closed

TestAddIndexFinishImportError is invalid #53641

D3Hunter opened this issue May 29, 2024 · 0 comments · Fixed by #53643
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

TestAddIndexFinishImportError depends on failpoint mockFinishImportErr which is run only when disttask is disabled, after #53233 the case always panics with disttask disabled, the case pass CI because distask is enabled on default now.

[2024/05/29 13:20:54.611 +08:00] [ERROR] [misc.go:114] ["panic in the recoverable goroutine"] [label=ddl] [funcInfo=onCreateIndex] [r="runtime error: invalid memory address or nil pointer dereference"] [stack="github.com/pingcap/tidb/pkg/util.Recover
    /Users/jujiajia/code/pingcap/tidb/pkg/util/misc.go:118
runtime.gopanic
    /usr/local/go/src/runtime/panic.go:920
runtime.panicmem
    /usr/local/go/src/runtime/panic.go:261
runtime.sigpanic
    /usr/local/go/src/runtime/signal_unix.go:861
github.com/pingcap/tidb/pkg/lightning/backend.(*OpenedEngine).LocalWriter
    /Users/jujiajia/code/pingcap/tidb/pkg/lightning/backend/backend.go:307
github.com/pingcap/tidb/pkg/ddl/ingest.(*engineInfo).newWriterContext
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/ingest/engine.go:224
github.com/pingcap/tidb/pkg/ddl/ingest.(*engineInfo).CreateWriter
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/ingest/engine.go:195
github.com/pingcap/tidb/pkg/ddl.newAddIndexIngestWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1680
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).createWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:482
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).setupWorkers.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:400
github.com/pingcap/tidb/pkg/resourcemanager/pool/workerpool.(*WorkerPool[...]).runAWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/resourcemanager/pool/workerpool/workerpool.go:135
github.com/pingcap/tidb/pkg/resourcemanager/pool/workerpool.(*WorkerPool[...]).Start
    /Users/jujiajia/code/pingcap/tidb/pkg/resourcemanager/pool/workerpool/workerpool.go:110
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).setupWorkers
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:403
github.com/pingcap/tidb/pkg/ddl.(*ddlCtx).writePhysicalTableRecord
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling.go:621
github.com/pingcap/tidb/pkg/ddl.(*worker).addPhysicalTableIndex
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1933
github.com/pingcap/tidb/pkg/ddl.(*worker).addTableIndex
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1979
github.com/pingcap/tidb/pkg/ddl.runReorgJobAndHandleErr.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1041
github.com/pingcap/tidb/pkg/ddl.(*worker).runReorgJob.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/reorg.go:205"] [stack="github.com/pingcap/tidb/pkg/util.Recover
    /Users/jujiajia/code/pingcap/tidb/pkg/util/misc.go:114
runtime.gopanic
    /usr/local/go/src/runtime/panic.go:920
runtime.panicmem
    /usr/local/go/src/runtime/panic.go:261
runtime.sigpanic
    /usr/local/go/src/runtime/signal_unix.go:861
github.com/pingcap/tidb/pkg/lightning/backend.(*OpenedEngine).LocalWriter
    /Users/jujiajia/code/pingcap/tidb/pkg/lightning/backend/backend.go:307
github.com/pingcap/tidb/pkg/ddl/ingest.(*engineInfo).newWriterContext
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/ingest/engine.go:224
github.com/pingcap/tidb/pkg/ddl/ingest.(*engineInfo).CreateWriter
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/ingest/engine.go:195
github.com/pingcap/tidb/pkg/ddl.newAddIndexIngestWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1680
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).createWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:482
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).setupWorkers.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:400
github.com/pingcap/tidb/pkg/resourcemanager/pool/workerpool.(*WorkerPool[...]).runAWorker
    /Users/jujiajia/code/pingcap/tidb/pkg/resourcemanager/pool/workerpool/workerpool.go:135
github.com/pingcap/tidb/pkg/resourcemanager/pool/workerpool.(*WorkerPool[...]).Start
    /Users/jujiajia/code/pingcap/tidb/pkg/resourcemanager/pool/workerpool/workerpool.go:110
github.com/pingcap/tidb/pkg/ddl.(*ingestBackfillScheduler).setupWorkers
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling_scheduler.go:403
github.com/pingcap/tidb/pkg/ddl.(*ddlCtx).writePhysicalTableRecord
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/backfilling.go:621
github.com/pingcap/tidb/pkg/ddl.(*worker).addPhysicalTableIndex
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1933
github.com/pingcap/tidb/pkg/ddl.(*worker).addTableIndex
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1979
github.com/pingcap/tidb/pkg/ddl.runReorgJobAndHandleErr.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/index.go:1041
github.com/pingcap/tidb/pkg/ddl.(*worker).runReorgJob.func1
    /Users/jujiajia/code/pingcap/tidb/pkg/ddl/reorg.go:205"]

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants