Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient panic when kill pd leader during br backup #54848

Open
crazycs520 opened this issue Jul 23, 2024 · 2 comments
Open

kvclient panic when kill pd leader during br backup #54848

crazycs520 opened this issue Jul 23, 2024 · 2 comments
Assignees
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. impact/panic severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@crazycs520
Copy link
Contributor

Bug Report

Related Issue: tikv/client-go#1357

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1、run br backup
2、kill pd leader
3、br backup failed
`panic: close of closed channel

goroutine 2822 [running]:
github.com/tikv/client-go/v2/internal/client.(*batchConn).Close(...)
/root/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240528025037-f41b068bf706/internal/client/client_batch.go:769
github.com/tikv/client-go/v2/internal/client.(*connArray).Close(0xc0004bb560)
/root/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240528025037-f41b068bf706/internal/client/client.go:330 +0xf6
github.com/tikv/client-go/v2/internal/client.(*RPCClient).CloseAddr(0xc0007e3680, {0xc000f7e7d0, 0x44})
/root/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240528025037-f41b068bf706/internal/client/client.go:797 +0x1e5
github.com/tikv/client-go/v2/internal/client.(*RPCClient).recycleIdleConnArray(0xc0007e3680)
/root/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240528025037-f41b068bf706/internal/client/client_batch.go:835 +0x1f7
created by github.com/tikv/client-go/v2/internal/client.(*RPCClient).sendRequest in goroutine 2821
/root/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240528025037-f41b068bf706/internal/client/client.go:587 +0x34b`

tidb version:
./tidb-server -V
Release Version: v7.5.2
Edition: Community
Git Commit Hash: 39ea2b3
Git Branch: HEAD
UTC Build Time: 2024-05-29 15:07:12
GoVersion: go1.21.10
Race Enabled: false
Check Table Before Drop: false
Store: unistore
2024-05-30T14:14:32.686+0800

@crazycs520 crazycs520 added type/bug The issue is confirmed as a bug. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.0 affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jul 23, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Jul 24, 2024
@crazycs520 crazycs520 removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@cfzjywxk
Copy link
Contributor

@crazycs520 Please verify if it is resolved in release-8.5 branch

@crazycs520 crazycs520 removed the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 14, 2024
@crazycs520
Copy link
Contributor Author

This issue doesn't affect release-8.5, since release-8.5 already contain the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. impact/panic severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants