Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrently written rows in REORGANIZE PARTITION may not be cleaned up #57523

Closed
mjonss opened this issue Nov 20, 2024 · 0 comments · Fixed by #56974
Closed

Concurrently written rows in REORGANIZE PARTITION may not be cleaned up #57523

mjonss opened this issue Nov 20, 2024 · 0 comments · Fixed by #56974
Assignees
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/tablepartition This issue is related to Table Partition of TiDB. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@mjonss
Copy link
Contributor

mjonss commented Nov 20, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Uncomment these lines, make failpoint-enable and run the test TestMultiSchemaReorganizePartition

2. What did you expect to see? (Required)

Test to pass, no old entries in old partitions ranges

3. What did you see instead (Required)

Reorganized (old partition) had still entries even after GC!

[2024/11/20 01:47:52.645 +01:00] [INFO] [multi_domain_test.go:704] [HaveEntriesForTableIndex] [tableID=111] [indexID=0] [count=1]
    multi_domain_test.go:472: 
        	Error Trace:	/Users/mattias/repos/tidb/pkg/ddl/tests/partition/multi_domain_test.go:472
        	            				/Users/mattias/repos/tidb/pkg/ddl/tests/partition/multi_domain_test.go:669
        	            				/Users/mattias/repos/tidb/pkg/ddl/tests/partition/multi_domain_test.go:475
        	Error:      	Should be false
        	Test:       	TestMultiSchemaReorganizePartition
        	Messages:   	Reorganized partition id 111 for table id 110 has still entries!
--- FAIL: TestMultiSchemaReorganizePartition (0.36s)

4. What is your TiDB version? (Required)

tidb_version(): Release Version: v8.5.0-alpha-163-g50b5cd27d4
Edition: Community
Git Commit Hash: 50b5cd27d41309a9b83d9c6e3529e15dd2cd60f9
Git Branch: master
UTC Build Time: 2024-11-20 00:54:03
GoVersion: go1.23.2
Race Enabled: false
Check Table Before Drop: false
Store: unistore
@mjonss mjonss added the type/bug The issue is confirmed as a bug. label Nov 20, 2024
@mjonss mjonss self-assigned this Nov 20, 2024
@mjonss mjonss added component/tablepartition This issue is related to Table Partition of TiDB. severity/major labels Nov 20, 2024
@mjonss mjonss added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.5 labels Nov 20, 2024
@jebter jebter added the sig/sql-infra SIG: SQL Infra label Nov 22, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 2125737 Nov 26, 2024
mjonss added a commit to ti-chi-bot/tidb that referenced this issue Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/tablepartition This issue is related to Table Partition of TiDB. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants