tikvclient: reduce wait backoff time when lock has be expired #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
changed the title
|
/run-all-tests |
|
@tiancaiamao PTAL can we do this? thx |
|
I like this idea @lysu |
|
You may remove the WIP label if it's ready for review |
Codecov Report
@@ Coverage Diff @@
## master #10006 +/- ##
================================================
+ Coverage 77.2589% 77.2756% +0.0166%
================================================
Files 413 413
Lines 86931 86964 +33
================================================
+ Hits 67162 67202 +40
+ Misses 14602 14599 -3
+ Partials 5167 5163 -4 |
|
/run-all-tests |
lysu
changed the title
|
/rebuild |
|
/run-all-tests |
jackysp
reviewed
May 13, 2019
| @@ -265,47 +266,59 @@ func (lr *LockResolver) BatchResolveLocks(bo *Backoffer, locks []*Lock, loc Regi | |||
| // commit status. | |||
| // 3) Send `ResolveLock` cmd to the lock's region to resolve all locks belong to | |||
| // the same transaction. | |||
| func (lr *LockResolver) ResolveLocks(bo *Backoffer, locks []*Lock) (ok bool, err error) { | |||
| func (lr *LockResolver) ResolveLocks(bo *Backoffer, locks []*Lock) (msBeforeTxnExpired int64, err error) { | |||
There was a problem hiding this comment.
msBeforeTxnExpired stands for "milliseconds before transaction expired"?
|
LGTM |
| @@ -102,8 +102,13 @@ func NewBackoffFn(base, cap, jitter int) func(ctx context.Context) int { | |||
| logutil.Logger(context.Background()).Debug("backoff", | |||
| zap.Int("base", base), | |||
| zap.Int("sleep", sleep)) | |||
|
|
|||
| realSleep := sleep | |||
| if maxSleepMs >= 0 && realSleep > maxSleepMs { | |||
There was a problem hiding this comment.
When the maxSleepMs will be 0?
There was a problem hiding this comment.
maxSleepMs never should be 0 in current usage, but backoff is a common function and we add new maxSleepMs Param, so we should take care about it and in logic "force sleep zero" is useful.
|
/run-all-tests |
|
/run-unit-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
we can precal lock expired time from kv response, then:
this PR maybe work better if tikv's tikv/tikv#4589 be merged(that decrease TTL)
What is changed and how it works?
calculate wait time by
UntilExpiredand force sleep not more than that.Check List
Tests
Code changes
Side effects
Related changes
This change is