Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table, infoschema, executor: fix Charset/Collation shown in column desc #10007

Merged
merged 4 commits into from
Apr 9, 2019
Merged

table, infoschema, executor: fix Charset/Collation shown in column desc #10007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
250c773
table, infoschema, executor: fix column desc
bb7133 Apr 2, 2019
ed824ba
address xiekeyi98's comment
bb7133 Apr 4, 2019
a07fd3a
fix CI
bb7133 Apr 8, 2019
0a19d05
address the comments of zimulala and xiekeyi98
bb7133 Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion executor/seqtest/seq_executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func (s *seqTestSuite) TestShow(c *C) {
tk.MustExec(`drop table if exists show_test_comment`)
tk.MustExec(`create table show_test_comment (id int not null default 0 comment "show_test_comment_id")`)
tk.MustQuery(`show full columns from show_test_comment`).Check(testutil.RowsWithSep("|",
"id|int(11)|binary|NO||0||select,insert,update,references|show_test_comment_id",
"id|int(11)|<nil>|NO||0||select,insert,update,references|show_test_comment_id",
))

// Test show create table with AUTO_INCREMENT option
Expand Down
7 changes: 0 additions & 7 deletions executor/show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,13 +370,6 @@ func (e *ShowExec) fetchShowColumns() error {
columnDefault = defaultValStr
}
}
// issue #9807
// Some types in show full columns should print other collations.
switch col.Tp {
case mysql.TypeTimestamp, mysql.TypeDate, mysql.TypeDuration, mysql.TypeDatetime,
mysql.TypeYear, mysql.TypeNewDate:
desc.Collation = "NULL"
}

// The FULL keyword causes the output to include the column collation and comments,
// as well as the privileges you have for each column.
Expand Down
64 changes: 56 additions & 8 deletions executor/show_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,66 @@ func (s *testSuite2) TestShow2(c *C) {
// TODO: In MySQL, the result is "autocommit ON".
tk2.MustQuery("show global variables where variable_name = 'autocommit'").Check(testkit.Rows("autocommit 1"))

// TODO: Specifying the charset for national char/varchar should not be supported.
tk.MustExec("drop table if exists test_full_column")
tk.MustExec(`create table test_full_column( a date , b datetime , c year(4), d timestamp,e time ,f year, h datetime(2) );`)
tk.MustExec(`create table test_full_column(
c_int int,
c_float float,
c_bit bit,
c_bool bool,
c_char char(1) charset ascii collate ascii_bin,
c_nchar national char(1) charset ascii collate ascii_bin,
c_binary binary,
c_varchar varchar(1) charset ascii collate ascii_bin,
c_nvarchar national varchar(1) charset ascii collate ascii_bin,
c_varbinary varbinary(1),
c_year year,
c_date date,
c_time time,
c_datetime datetime,
c_timestamp timestamp,
c_blob blob,
c_tinyblob tinyblob,
c_mediumblob mediumblob,
c_longblob longblob,
c_text text charset ascii collate ascii_bin,
c_tinytext tinytext charset ascii collate ascii_bin,
c_mediumtext mediumtext charset ascii collate ascii_bin,
c_longtext longtext charset ascii collate ascii_bin,
c_json json,
c_enum enum('1') charset ascii collate ascii_bin,
c_set set('1') charset ascii collate ascii_bin
);`)

tk.MustQuery(`show full columns from test_full_column`).Check(testkit.Rows(
"" +
"a date NULL YES <nil> select,insert,update,references ]\n" +
"[b datetime NULL YES <nil> select,insert,update,references ]\n" +
"[c year(4) NULL YES <nil> select,insert,update,references ]\n" +
"[d timestamp NULL YES <nil> select,insert,update,references ]\n" +
"[e time NULL YES <nil> select,insert,update,references ]\n" +
"[f year(4) NULL YES <nil> select,insert,update,references ]\n" +
"[h datetime(2) NULL YES <nil> select,insert,update,references "))
"c_int int(11) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_float float <nil> YES <nil> select,insert,update,references ]\n" +
"[c_bit bit(1) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_bool tinyint(1) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_char char(1) ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_nchar char(1) ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_binary binary(1) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_varchar varchar(1) ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_nvarchar varchar(1) ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_varbinary varbinary(1) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_year year(4) <nil> YES <nil> select,insert,update,references ]\n" +
"[c_date date <nil> YES <nil> select,insert,update,references ]\n" +
"[c_time time <nil> YES <nil> select,insert,update,references ]\n" +
"[c_datetime datetime <nil> YES <nil> select,insert,update,references ]\n" +
"[c_timestamp timestamp <nil> YES <nil> select,insert,update,references ]\n" +
"[c_blob blob <nil> YES <nil> select,insert,update,references ]\n" +
"[c_tinyblob tinyblob <nil> YES <nil> select,insert,update,references ]\n" +
"[c_mediumblob mediumblob <nil> YES <nil> select,insert,update,references ]\n" +
"[c_longblob longblob <nil> YES <nil> select,insert,update,references ]\n" +
"[c_text text ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_tinytext tinytext ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_mediumtext mediumtext ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_longtext longtext ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_json json <nil> YES <nil> select,insert,update,references ]\n" +
"[c_enum enum('1') ascii_bin YES <nil> select,insert,update,references ]\n" +
"[c_set set('1') ascii_bin YES <nil> select,insert,update,references "))

tk.MustExec("drop table if exists test_full_column")

tk.MustExec("drop table if exists t")
Expand Down
10 changes: 2 additions & 8 deletions infoschema/tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,21 +1155,15 @@ func dataForColumnsInTable(schema *model.DBInfo, tbl *model.TableInfo) [][]types
numericPrecision, // NUMERIC_PRECISION
numericScale, // NUMERIC_SCALE
datetimePrecision, // DATETIME_PRECISION
col.Charset, // CHARACTER_SET_NAME
col.Collate, // COLLATION_NAME
columnDesc.Charset, // CHARACTER_SET_NAME
columnDesc.Collation, // COLLATION_NAME
columnType, // COLUMN_TYPE
columnDesc.Key, // COLUMN_KEY
columnDesc.Extra, // EXTRA
"select,insert,update,references", // PRIVILEGES
columnDesc.Comment, // COLUMN_COMMENT
col.GeneratedExprString, // GENERATION_EXPRESSION
)
// In mysql, 'character_set_name' and 'collation_name' are setted to null when column type is non-varchar or non-blob in information_schema.
if col.Tp != mysql.TypeVarchar && col.Tp != mysql.TypeBlob {
record[13].SetNull()
record[14].SetNull()
}

rows = append(rows, record)
}
return rows
Expand Down
69 changes: 69 additions & 0 deletions infoschema/tables_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ func (s *testTableSuite) TestDataForTableStatsField(c *C) {

do := s.dom
h := do.StatsHandle()
h.Clear()
is := do.InfoSchema()
tk := testkit.NewTestKit(c, s.store)

Expand Down Expand Up @@ -168,6 +169,74 @@ func (s *testTableSuite) TestCharacterSetCollations(c *C) {
// but the id's are used by client libraries and must be stable
tk.MustQuery("SELECT character_set_name, id, sortlen FROM information_schema.collations ORDER BY collation_name").Check(
testkit.Rows("armscii8 64 1", "armscii8 32 1", "ascii 65 1", "ascii 11 1", "big5 84 1", "big5 1 1", "binary 63 1", "cp1250 66 1", "cp1250 44 1", "cp1250 34 1", "cp1250 26 1", "cp1250 99 1", "cp1251 50 1", "cp1251 14 1", "cp1251 51 1", "cp1251 52 1", "cp1251 23 1", "cp1256 67 1", "cp1256 57 1", "cp1257 58 1", "cp1257 59 1", "cp1257 29 1", "cp850 80 1", "cp850 4 1", "cp852 81 1", "cp852 40 1", "cp866 68 1", "cp866 36 1", "cp932 96 1", "cp932 95 1", "dec8 69 1", "dec8 3 1", "eucjpms 98 1", "eucjpms 97 1", "euckr 85 1", "euckr 19 1", "gb2312 86 1", "gb2312 24 1", "gbk 87 1", "gbk 28 1", "geostd8 93 1", "geostd8 92 1", "greek 70 1", "greek 25 1", "hebrew 71 1", "hebrew 16 1", "hp8 72 1", "hp8 6 1", "keybcs2 73 1", "keybcs2 37 1", "koi8r 74 1", "koi8r 7 1", "koi8u 75 1", "koi8u 22 1", "latin1 47 1", "latin1 15 1", "latin1 48 1", "latin1 49 1", "latin1 5 1", "latin1 31 1", "latin1 94 1", "latin1 8 1", "latin2 77 1", "latin2 27 1", "latin2 2 1", "latin2 9 1", "latin2 21 1", "latin5 78 1", "latin5 30 1", "latin7 79 1", "latin7 20 1", "latin7 41 1", "latin7 42 1", "macce 43 1", "macce 38 1", "macroman 53 1", "macroman 39 1", "sjis 88 1", "sjis 13 1", "swe7 82 1", "swe7 10 1", "tis620 89 1", "tis620 18 1", "ucs2 90 1", "ucs2 149 1", "ucs2 138 1", "ucs2 139 1", "ucs2 145 1", "ucs2 134 1", "ucs2 35 1", "ucs2 159 1", "ucs2 148 1", "ucs2 146 1", "ucs2 129 1", "ucs2 130 1", "ucs2 140 1", "ucs2 144 1", "ucs2 133 1", "ucs2 143 1", "ucs2 131 1", "ucs2 147 1", "ucs2 141 1", "ucs2 132 1", "ucs2 142 1", "ucs2 135 1", "ucs2 136 1", "ucs2 137 1", "ucs2 150 1", "ucs2 128 1", "ucs2 151 1", "ujis 91 1", "ujis 12 1", "utf16 55 1", "utf16 122 1", "utf16 111 1", "utf16 112 1", "utf16 118 1", "utf16 107 1", "utf16 54 1", "utf16 121 1", "utf16 119 1", "utf16 102 1", "utf16 103 1", "utf16 113 1", "utf16 117 1", "utf16 106 1", "utf16 116 1", "utf16 104 1", "utf16 120 1", "utf16 114 1", "utf16 105 1", "utf16 115 1", "utf16 108 1", "utf16 109 1", "utf16 110 1", "utf16 123 1", "utf16 101 1", "utf16 124 1", "utf16le 62 1", "utf16le 56 1", "utf32 61 1", "utf32 181 1", "utf32 170 1", "utf32 171 1", "utf32 177 1", "utf32 166 1", "utf32 60 1", "utf32 180 1", "utf32 178 1", "utf32 161 1", "utf32 162 1", "utf32 172 1", "utf32 176 1", "utf32 165 1", "utf32 175 1", "utf32 163 1", "utf32 179 1", "utf32 173 1", "utf32 164 1", "utf32 174 1", "utf32 167 1", "utf32 168 1", "utf32 169 1", "utf32 182 1", "utf32 160 1", "utf32 183 1", "utf8 83 1", "utf8 213 1", "utf8 202 1", "utf8 203 1", "utf8 209 1", "utf8 198 1", "utf8 33 1", "utf8 223 1", "utf8 212 1", "utf8 210 1", "utf8 193 1", "utf8 194 1", "utf8 204 1", "utf8 208 1", "utf8 197 1", "utf8 207 1", "utf8 195 1", "utf8 211 1", "utf8 205 1", "utf8 196 1", "utf8 206 1", "utf8 199 1", "utf8 200 1", "utf8 201 1", "utf8 214 1", "utf8 192 1", "utf8 215 1", "utf8mb4 46 1", "utf8mb4 245 1", "utf8mb4 234 1", "utf8mb4 235 1", "utf8mb4 241 1", "utf8mb4 230 1", "utf8mb4 45 1", "utf8mb4 244 1", "utf8mb4 242 1", "utf8mb4 225 1", "utf8mb4 226 1", "utf8mb4 236 1", "utf8mb4 240 1", "utf8mb4 229 1", "utf8mb4 239 1", "utf8mb4 227 1", "utf8mb4 243 1", "utf8mb4 237 1", "utf8mb4 228 1", "utf8mb4 238 1", "utf8mb4 231 1", "utf8mb4 232 1", "utf8mb4 233 1", "utf8mb4 246 1", "utf8mb4 224 1", "utf8mb4 247 1"))

// Test charset/collation in information_schema.COLUMNS table.
tk.MustExec("DROP DATABASE IF EXISTS charset_collate_test")
tk.MustExec("CREATE DATABASE charset_collate_test; USE charset_collate_test")

// TODO: Specifying the charset for national char/varchar should not be supported.
tk.MustExec(`CREATE TABLE charset_collate_col_test(
c_int int,
c_float float,
c_bit bit,
c_bool bool,
c_char char(1) charset ascii collate ascii_bin,
c_nchar national char(1) charset ascii collate ascii_bin,
c_binary binary,
c_varchar varchar(1) charset ascii collate ascii_bin,
c_nvarchar national varchar(1) charset ascii collate ascii_bin,
c_varbinary varbinary(1),
c_year year,
c_date date,
c_time time,
c_datetime datetime,
c_timestamp timestamp,
c_blob blob,
c_tinyblob tinyblob,
c_mediumblob mediumblob,
c_longblob longblob,
c_text text charset ascii collate ascii_bin,
c_tinytext tinytext charset ascii collate ascii_bin,
c_mediumtext mediumtext charset ascii collate ascii_bin,
c_longtext longtext charset ascii collate ascii_bin,
c_json json,
c_enum enum('1') charset ascii collate ascii_bin,
c_set set('1') charset ascii collate ascii_bin
)`)

tk.MustQuery(`SELECT column_name, character_set_name, collation_name
FROM information_schema.COLUMNS
WHERE table_schema = "charset_collate_test" AND table_name = "charset_collate_col_test"
ORDER BY column_name`,
).Check(testkit.Rows(
"c_binary <nil> <nil>",
"c_bit <nil> <nil>",
"c_blob <nil> <nil>",
"c_bool <nil> <nil>",
"c_char ascii ascii_bin",
"c_date <nil> <nil>",
"c_datetime <nil> <nil>",
"c_enum ascii ascii_bin",
"c_float <nil> <nil>",
"c_int <nil> <nil>",
"c_json <nil> <nil>",
"c_longblob <nil> <nil>",
"c_longtext ascii ascii_bin",
"c_mediumblob <nil> <nil>",
"c_mediumtext ascii ascii_bin",
"c_nchar ascii ascii_bin",
"c_nvarchar ascii ascii_bin",
"c_set ascii ascii_bin",
"c_text ascii ascii_bin",
"c_time <nil> <nil>",
"c_timestamp <nil> <nil>",
"c_tinyblob <nil> <nil>",
"c_tinytext ascii ascii_bin",
"c_varbinary <nil> <nil>",
"c_varchar ascii ascii_bin",
"c_year <nil> <nil>",
))
tk.MustExec("DROP DATABASE charset_collate_test")
}

type mockSessionManager struct {
Expand Down
18 changes: 14 additions & 4 deletions table/column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/pingcap/parser/charset"
"github.com/pingcap/parser/model"
"github.com/pingcap/parser/mysql"
field_types "github.com/pingcap/parser/types"
"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/expression"
"github.com/pingcap/tidb/sessionctx"
Expand Down Expand Up @@ -205,9 +206,12 @@ func CastValue(ctx sessionctx.Context, val types.Datum, col *model.ColumnInfo) (

// ColDesc describes column information like MySQL desc and show columns do.
type ColDesc struct {
Field string
Type string
Collation string
Field string
Type string
// Charset is nil if the column doesn't have a charset, or a string indicating the charset name.
Charset interface{}
// Collation is nil if the column doesn't have a collation, or a string indicating the collation name.
Collation interface{}
Null string
Key string
DefaultValue interface{}
Expand Down Expand Up @@ -267,9 +271,10 @@ func NewColDesc(col *Column) *ColDesc {
}
}

return &ColDesc{
desc := &ColDesc{
Field: name.O,
Type: col.GetTypeDesc(),
Charset: col.Charset,
Collation: col.Collate,
Null: nullFlag,
Key: keyFlag,
Expand All @@ -278,6 +283,11 @@ func NewColDesc(col *Column) *ColDesc {
Privileges: defaultPrivileges,
Comment: col.Comment,
}
if !field_types.HasCharset(&col.ColumnInfo.FieldType) {
desc.Charset = nil
desc.Collation = nil
}
return desc
}

// ColDescFieldNames returns the fields name in result set for desc and show columns.
Expand Down