Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: only owner do bootstrap #10029

Merged
merged 13 commits into from
Apr 11, 2019
Merged

server: only owner do bootstrap #10029

Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6211344
server: only owner do bootstrap
crazycs520 Apr 3, 2019
ff56efe
Merge branch 'master' into bootstrap-in-owner
crazycs520 Apr 3, 2019
7057924
Address comment
crazycs520 Apr 8, 2019
b1f2d6c
Merge branch 'master' into bootstrap-in-owner
crazycs520 Apr 8, 2019
67e3f76
address comment
crazycs520 Apr 9, 2019
3fb8864
Merge branch 'bootstrap-in-owner' of https://github.com/crazycs520/ti…
crazycs520 Apr 9, 2019
ee7fd24
enlarge sleep time when bootstrap
crazycs520 Apr 10, 2019
259c084
Merge branch 'master' into bootstrap-in-owner
crazycs520 Apr 10, 2019
45d052f
fix bug for upgrade
crazycs520 Apr 10, 2019
a47e6e6
Merge branch 'bootstrap-in-owner' of https://github.com/crazycs520/ti…
crazycs520 Apr 10, 2019
42306a8
Merge branch 'master' into bootstrap-in-owner
crazycs520 Apr 10, 2019
dce035b
Merge branch 'master' into bootstrap-in-owner
crazycs520 Apr 10, 2019
ad1e87a
Merge branch 'master' into bootstrap-in-owner
zz-jason Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions session/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"github.com/pingcap/parser/mysql"
"github.com/pingcap/parser/terror"
"github.com/pingcap/tidb/ddl"
"github.com/pingcap/tidb/domain"
"github.com/pingcap/tidb/infoschema"
"github.com/pingcap/tidb/sessionctx/variable"
"github.com/pingcap/tidb/util/chunk"
Expand Down Expand Up @@ -250,17 +251,26 @@ const (

// bootstrap initiates system DB for a store.
func bootstrap(s Session) {
b, err := checkBootstrapped(s)
if err != nil {
logutil.Logger(context.Background()).Fatal("check bootstrap error",
zap.Error(err))
}
if b {
upgrade(s)
return
dom := domain.GetDomain(s)
for {
b, err := checkBootstrapped(s)
if err != nil {
logutil.Logger(context.Background()).Fatal("check bootstrap error",
zap.Error(err))
}
// To reduce conflict when multiple TiDB-server start at the same time.
// Actually only one server need to do the bootstrap. So we chose DDL owner to do this.
if dom.DDL().OwnerManager().IsOwner() {
crazycs520 marked this conversation as resolved.
Show resolved Hide resolved
if b {
upgrade(s)
return
}
doDDLWorks(s)
doDMLWorks(s)
return
}
time.Sleep(200 * time.Millisecond)
}
doDDLWorks(s)
doDMLWorks(s)
}

const (
Expand Down