Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ranger: choose more prefix columns when building ranges #10053

Merged
merged 4 commits into from
Apr 24, 2019
Merged

ranger: choose more prefix columns when building ranges #10053

merged 4 commits into from
Apr 24, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Apr 4, 2019

What problem does this PR solve?

Fix #10027

What is changed and how it works?

Return eqOrInCount instead of eqCount in detachCNFCondAndBuildRangeForIndex for subsequent detach.

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

N/A

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner status/WIP labels Apr 4, 2019
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 8, 2019

/run-all-tests

1 similar comment
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 8, 2019

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 8, 2019

/run-common-test
/run-integration-common-test
/run-unit-test

@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@862df46). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #10053   +/-   ##
===========================================
  Coverage          ?   77.9572%           
===========================================
  Files             ?        407           
  Lines             ?      83465           
  Branches          ?          0           
===========================================
  Hits              ?      65067           
  Misses            ?      13571           
  Partials          ?       4827

@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 8, 2019

/run-all-tests

@eurekaka eurekaka marked this pull request as ready for review April 9, 2019 02:40
alivxxx
alivxxx reviewed Apr 9, 2019
View reviewed changes
util/ranger/detacher.go Outdated Show resolved Hide resolved
alivxxx
alivxxx reviewed Apr 9, 2019
View reviewed changes
util/ranger/detacher.go Outdated Show resolved Hide resolved
winoros
winoros reviewed Apr 9, 2019
View reviewed changes
util/ranger/detacher.go Outdated Show resolved Hide resolved
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka requested review from qw4990, winoros and alivxxx and removed request for qw4990 April 23, 2019 05:47
qw4990
qw4990 reviewed Apr 24, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winoros
winoros approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 24, 2019
@eurekaka eurekaka merged commit b5890b3 into pingcap:master Apr 24, 2019
@eurekaka eurekaka deleted the eq_or_in_count branch April 24, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@winoros winoros winoros approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhance ranger to choose more prefix columns when building ranges
5 participants
@eurekaka @qw4990 @winoros @alivxxx @zz-jason