Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle maketime unsigned hour overflow #10074

Merged
merged 2 commits into from
Apr 9, 2019
Merged

expression: handle maketime unsigned hour overflow #10074

merged 2 commits into from
Apr 9, 2019

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Apr 8, 2019 •
edited by zz-jason
Loading

What problem does this PR solve?

fix #9735

What is changed and how it works?

If hour<0 and hour is unsigned    
   then overflow should true and hour should set to max_hour

Check List

Tests

  • Unit test

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Apr 8, 2019

@qw4990 PTAL

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Apr 8, 2019

/run-all-tests

zz-jason
zz-jason reviewed Apr 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2019
@zz-jason zz-jason requested a review from qw4990 April 9, 2019 02:15
winoros
winoros approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #10074 into master will decrease coverage by 0.0166%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10074        +/-   ##
================================================
- Coverage   78.0444%   78.0277%   -0.0167%     
================================================
  Files           404        404                
  Lines         81970      81999        +29     
================================================
+ Hits          63973      63982         +9     
- Misses        13308      13320        +12     
- Partials       4689       4697         +8

@qw4990
Copy link
Contributor

qw4990 commented Apr 9, 2019

/rebuild

@qw4990 qw4990 merged commit 826c299 into pingcap:master Apr 9, 2019
@qw4990
Copy link
Contributor

qw4990 commented Apr 9, 2019

@AndrewDi Thanks for your contribution, could you please cherry-pick this PR to branch release-2.1.

@AndrewDi AndrewDi mentioned this pull request Apr 9, 2019
Merged
@AndrewDi AndrewDi deleted the fix_maketime_func branch April 9, 2019 14:02
@qw4990 qw4990 mentioned this pull request Apr 10, 2019
Closed
30 tasks
zz-jason pushed a commit that referenced this pull request Apr 11, 2019
@AndrewDi @zz-jason
expression: handle maketime unsigned hour overflow(#10074) (#10089)
998cbf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAKETIME is not compatible with Mysql
4 participants
@AndrewDi @qw4990 @zz-jason @winoros