Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: generate digest and log it in slow log (#9662) #10093

Merged
merged 8 commits into from
Apr 11, 2019
Merged

log: generate digest and log it in slow log (#9662) #10093

merged 8 commits into from
Apr 11, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Apr 10, 2019

cherry-pick #9662 to 2.1

DO NOT merge until pingcap/parser#279 done thx


This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@lysu
Copy link
Contributor Author

lysu commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2019
@crazycs520
Copy link
Contributor

@jackysp PTAL

go.mod Outdated Show resolved Hide resolved
@lysu
Copy link
Contributor Author

lysu commented Apr 10, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

zz-jason
zz-jason previously approved these changes Apr 10, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2019
jackysp
jackysp previously approved these changes Apr 10, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu dismissed stale reviews from jackysp and zz-jason via 8ec79a6 April 10, 2019 13:25
@zz-jason
Copy link
Member

@lysu please resolve conflicts.

@lysu
Copy link
Contributor Author

lysu commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@ngaut ngaut merged commit a4707e2 into pingcap:release-2.1 Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants