-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: correct range calculation for CHAR column #10124
Conversation
…n/tidb into bugfix/point-get-char-pk
/run-all-tests |
/run-integration-common-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check:
create table t(a binary(2) primary key, b char(2));
insert into t values("a ", "b");
insert into t values("a", "b");
select * from t where a = "a ";
MySQL:
mysql> select * from t where a = "a ";
+----+------+
| a | b |
+----+------+
| a | b |
+----+------+
1 row in set (0.00 sec)
TiDB:
tidb> select * from t where a = "a ";
Empty set (0.00 sec)
tidb> desc select * from t where a = "a ";
+-------------+-------+------+------------------+
| id | count | task | operator info |
+-------------+-------+------+------------------+
| Point_Get_1 | 1.00 | root | table:t, index:a |
+-------------+-------+------+------------------+
1 row in set (0.00 sec)
/rebuild |
/run-all-tests |
/run-mybatis-test |
Codecov Report
@@ Coverage Diff @@
## master #10124 +/- ##
================================================
+ Coverage 77.3299% 77.3444% +0.0144%
================================================
Files 412 412
Lines 86546 86566 +20
================================================
+ Hits 66926 66954 +28
+ Misses 14486 14479 -7
+ Partials 5134 5133 -1 |
…n/tidb into bugfix/point-get-char-pk
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
fix the wrong range calculation for:
This PR can:
What is changed and how it works?
specially handle the "PAD_CHAR_TO_FULL_LENGTH" for char column.
Check List
Tests
Related changes