-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: show more information about cop tasks in slow log #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
reviewed
Apr 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #10165 +/- ##
================================================
+ Coverage 77.9168% 77.9356% +0.0187%
================================================
Files 407 405 -2
Lines 82588 82350 -238
================================================
- Hits 64350 64180 -170
+ Misses 13473 13426 -47
+ Partials 4765 4744 -21 |
zz-jason
reviewed
Apr 17, 2019
alivxxx
reviewed
Apr 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Apr 18, 2019
/run-all-tests |
1 similar comment
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Show more information about cop tasks in slow log.
What is changed and how it works?
allExecDetails
inStatementContext
to record all cop-tasks' execution information.CopTasksDetails
to calculate and generate some useful information about cop-tasks.SlowLogFormat
to put cop-task execution information into slow log.Check List
Tests