Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: show more information about cop tasks in slow log #10165

Merged
merged 8 commits into from
Apr 18, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 16, 2019

What problem does this PR solve?

Show more information about cop tasks in slow log.

What is changed and how it works?

  1. Add allExecDetails in StatementContext to record all cop-tasks' execution information.
  2. Add CopTasksDetails to calculate and generate some useful information about cop-tasks.
  3. Update SlowLogFormat to put cop-task execution information into slow log.

Check List

Tests

  • Unit test

@qw4990 qw4990 added the sig/execution SIG execution label Apr 16, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #10165 into master will increase coverage by 0.0187%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10165        +/-   ##
================================================
+ Coverage   77.9168%   77.9356%   +0.0187%     
================================================
  Files           407        405         -2     
  Lines         82588      82350       -238     
================================================
- Hits          64350      64180       -170     
+ Misses        13473      13426        -47     
+ Partials       4765       4744        -21

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2019
@zz-jason
Copy link
Member

/run-all-tests

1 similar comment
@ngaut
Copy link
Member

ngaut commented Apr 18, 2019

/run-all-tests

@ngaut ngaut merged commit 2a6c8d6 into pingcap:master Apr 18, 2019
qw4990 added a commit to qw4990/tidb that referenced this pull request Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants