executor: fix the wrong order by pk desc result and some corner cases for unsigned pk
#10179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for unsigned pk
qw4990
reviewed
Apr 17, 2019
|
/run-all-tests |
|
/run-all-tests |
|
/run-common-test |
|
/run-common-test |
XuHuaiyu
reviewed
Apr 18, 2019
There was a problem hiding this comment.
The comments of
type tableResultHandler struct {
// If the pk is unsigned and we have KeepOrder=true.
// optionalResult handles the request whose range is in signed int range.
// result handles the request whose range is exceed signed int range.
// Otherwise, we just set optionalFinished true and the result handles the whole ranges.
optionalResult distsql.SelectResult
result distsql.SelectResult
optionalFinished bool
}should be updated?
| HighVal: ranges[idx].HighVal, | ||
| HighExclude: ranges[idx].HighExclude, | ||
| }) | ||
| if !(ranges[idx].LowVal[0].GetUint64() == math.MaxInt64 && ranges[idx].LowExclude) { |
There was a problem hiding this comment.
Why do we need this check?
There was a problem hiding this comment.
Because there can be cases like (maxInt64, maxInt64] and [maxInt64+1, maxInt64+1)`. And then error thrown when send requests.
Codecov Report
@@ Coverage Diff @@
## master #10179 +/- ##
================================================
- Coverage 77.9301% 77.9269% -0.0033%
================================================
Files 407 407
Lines 82964 82911 -53
================================================
- Hits 64654 64610 -44
+ Misses 13514 13510 -4
+ Partials 4796 4791 -5 |
|
/run-all-tests |
zz-jason
added
sig/execution
|
Please cherry-pick this to the release-2.1 branch. |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Apr 22, 2019
…es for unsigned pk (pingcap#10179)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10178
What is changed and how it works?
When split ranges, we forget to check the
DESCstatus and some corner case checking.Check List
Tests
Related changes