Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix stack overflow caused by folding constant #10189

Merged
merged 3 commits into from
Apr 18, 2019
Merged

planner: fix stack overflow caused by folding constant #10189

merged 3 commits into from
Apr 18, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 18, 2019

cherry-pick for #10174.

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Apr 18, 2019
@qw4990 qw4990 requested review from zz-jason and alivxxx April 18, 2019 07:10
alivxxx
alivxxx reviewed Apr 18, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2019
winoros
winoros previously approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

/rebuild

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 18, 2019

All checks have passed, PTAL~

zz-jason
zz-jason approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 7bf69bd into pingcap:release-2.1 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@winoros winoros winoros left review comments

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @zz-jason @winoros @alivxxx