Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: trace and control memory usage in DistSQL layer (#10003) #10197

Merged
merged 3 commits into from
Apr 22, 2019
Merged

executor: trace and control memory usage in DistSQL layer (#10003) #10197

merged 3 commits into from
Apr 22, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 19, 2019

cherry-pick for #10003.

zz-jason
zz-jason reviewed Apr 19, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 19, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested a review from lysu April 19, 2019 03:30
alivxxx
alivxxx approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2019
@lonng
Copy link
Contributor

lonng commented Apr 22, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 22, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit a52c48b into pingcap:release-2.1 Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @lonng @zz-jason @alivxxx