Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix error in ParseSlowLog #10526

Merged
merged 1 commit into from
May 17, 2019
Merged

infoschema: fix error in ParseSlowLog #10526

merged 1 commit into from
May 17, 2019

Conversation

killua525
Copy link

What problem does this PR solve?

sql: select * from INFORMATION_SCHEMA.SLOW_QUERY limit 1;
return ERROR 1105 (HY000): string "2019-05-12-11:23:29.61474688" doesn't has a prefix that matches format "2006-01-02-15:04:05.999999999 -0700", err: parsing time "2019-05-12-11:23:29.61474688" as "2006-01-02-15:04:05.999999999 -0700": cannot parse "" as "-0700"

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@CLAassistant
Copy link

CLAassistant commented May 17, 2019

CLA assistant check
All committers have signed the CLA.

@shenli shenli added type/bugfix This PR fixes a bug. contribution This PR is from a community contributor. labels May 17, 2019
- issue
sql: `select * from INFORMATION_SCHEMA.SLOW_QUERY limit 1;`
return `ERROR 1105 (HY000): string "2019-05-12-11:23:29.61474688" doesn't has a prefix that matches format "2006-01-02-15:04:05.999999999 -0700", err: parsing time "2019-05-12-11:23:29.61474688" as "2006-01-02-15:04:05.999999999 -0700": cannot parse "" as "-0700"`
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #10526 into master will increase coverage by 0.0301%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10526        +/-   ##
================================================
+ Coverage   77.2733%   77.3034%   +0.0301%     
================================================
  Files           413        413                
  Lines         86964      86912        -52     
================================================
- Hits          67200      67186        -14     
+ Misses        14601      14573        -28     
+ Partials       5163       5153        -10

@crazycs520
Copy link
Contributor

@jzdxeb Thanks for contribution.
BTW, which tidb-version do you use when you find this bug?

@killua525
Copy link
Author

@jzdxeb Thanks for contribution.
BTW, which tidb-version do you use when you find this bug?

bug in version 2.1.8 2.1.9

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@zz-jason zz-jason changed the title bugfix: ParseSlowLog infoschema: fix error in ParseSlowLog May 17, 2019
@zz-jason zz-jason merged commit 04d4910 into pingcap:master May 17, 2019
@killua525 killua525 deleted the bugfix branch May 17, 2019 23:58
crazycs520 added a commit to crazycs520/tidb that referenced this pull request May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants