-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add show table regions syntax #10612
Conversation
PTAL @morgo |
Should we call the syntax |
@morgo, Great, I will change this syntax later. |
No problem! Don't feel you have to follow this advice if it doesn't make sense to you. |
@morgo |
@winkyao you are right. We may need to take a look at other admin commands ( |
@morgo , I want to change this syntax to Because of I found that syntax is nothing to do with the split table. I can just use this syntax to check the table regions status/information. |
LGTM (assuming this command is read-only of course). |
Codecov Report
@@ Coverage Diff @@
## master #10612 +/- ##
=========================================
Coverage 81.261% 81.261%
=========================================
Files 423 423
Lines 91334 91334
=========================================
Hits 74219 74219
Misses 11822 11822
Partials 5293 5293 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
LGTM @winkyao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
Related Parser PR: pingcap/parser#349
Add sql syntax to check split table region status.
What is changed and how it works?
eg
Check List
Tests
Code changes
Side effects
Related changes