Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: execute some statement (create user grant etc) would commit current transaction automically #10707

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Fix #10705

What is changed and how it works?

New a transaction before "create user", "grant", "revoke" and so on

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@tiancaiamao tiancaiamao added type/bugfix This PR fixes a bug. sig/execution SIG execution labels Jun 4, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @zimulala @winkyao

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #10707 into master will increase coverage by 0.003%.
The diff coverage is 71.4285%.

@@               Coverage Diff               @@
##             master     #10707       +/-   ##
===============================================
+ Coverage   79.5551%   79.5581%   +0.003%     
===============================================
  Files           415        415               
  Lines         88066      88133       +67     
===============================================
+ Hits          70061      70117       +56     
- Misses        12812      12821        +9     
- Partials       5193       5195        +2

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE USER/GRANT PRIVILEGE should begin a new transaction
3 participants