*: rename and add tidb_wait_split_region_finish_backoff session var to set wait split region backoff time. #10797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
reviewed
Jun 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #10797 +/- ##
================================================
+ Coverage 80.9047% 80.9465% +0.0417%
================================================
Files 419 419
Lines 88750 88787 +37
================================================
+ Hits 71803 71870 +67
+ Misses 11714 11680 -34
- Partials 5233 5237 +4 |
zimulala
reviewed
Jun 17, 2019
zimulala
reviewed
Jun 17, 2019
sessionctx/variable/session.go
Outdated
| case TiDBWaitSplitRegionFinish: | ||
| s.WaitSplitRegionFinish = TiDBOptOn(val) | ||
| case TiDBWaitSplitRegionFinishBackoff: | ||
| s.Backoff.SetWaitScatterRegionFinishBackoff(int(tidbOptInt64(val, backoff.WaitScatterRegionFinishBackoff))) |
There was a problem hiding this comment.
I think we add function like tidbOptPositiveInt32 is enough. Then we remove backoff_time.go
zimulala
reviewed
Jun 19, 2019
zimulala
reviewed
Jun 19, 2019
sessionctx/variable/session.go
Outdated
|
|
||
| // GetWaitScatterRegionFinishBackoff gets the back off time of waitScatterRegionFinish. | ||
| func (b *BackoffTimer) GetWaitScatterRegionFinishBackoff() int { | ||
| if b.waitScatterRegionFinish > 0 { |
There was a problem hiding this comment.
If we use tidbOptPositiveInt32 to set the value. I think we needn't do this.
|
/run-all-tests |
zimulala
added
status/LGT2
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
winkyao
approved these changes
Jun 20, 2019
|
/run-unit-test |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jun 20, 2019
…set wait split region timeout. (pingcap#10797)
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 10, 2019
…set wait split region timeout. (pingcap#10797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tidb_wait_split_region_finish_backoffto set the split region back off time.tidb_wait_split_region_finishdefault value to true. We meet some performence problem cause by defaultasync scatterbehaviour . So we decide change this default behaviour tosync scatter.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes