executor: locks key in point get executor for pessimistic transaction #10972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #10972 +/- ##
================================================
- Coverage 80.9745% 80.9125% -0.0621%
================================================
Files 418 418
Lines 89412 89221 -191
================================================
- Hits 72401 72191 -210
- Misses 11783 11795 +12
- Partials 5228 5235 +7 |
|
LGTM |
jackysp
added
status/LGT2
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Jun 28, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 1, 2019
This was referenced Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When a pessimistic transaction uses a primary key or unique key to lock read or update/delete a row, if the result is empty, the key will not be locked, the next insert may return duplicated key error.
What is changed and how it works?
Locks the key in point get plan, even if the value is empty.
It prevents phantom read if the read is a point get.
Check List
Tests
Code changes
Related changes