meta: make auto increment id can be adjust. #10978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
changed the title
Codecov Report
@@ Coverage Diff @@
## master #10978 +/- ##
===============================================
- Coverage 80.9317% 80.9007% -0.031%
===============================================
Files 418 418
Lines 89253 89192 -61
===============================================
- Hits 72234 72157 -77
- Misses 11785 11797 +12
- Partials 5234 5238 +4 |
Codecov Report
@@ Coverage Diff @@
## master #10978 +/- ##
================================================
- Coverage 80.9364% 80.9305% -0.0059%
================================================
Files 418 418
Lines 89212 89237 +25
================================================
+ Hits 72205 72220 +15
- Misses 11777 11785 +8
- Partials 5230 5232 +2 |
|
/run-all-tests |
coocood
reviewed
Jun 28, 2019
meta/autoid/autoid.go
Outdated
| @@ -214,14 +223,17 @@ func (alloc *allocator) alloc4Unsigned(tableID int64) (int64, error) { | |||
| if alloc.base == alloc.end { // step | |||
| var newBase, newEnd int64 | |||
| startTime := time.Now() | |||
| consumeDur := startTime.Sub(alloc.lastAllocTime) | |||
| alloc.step = NextStep(alloc.step, consumeDur) | |||
| alloc.lastAllocTime = startTime | |||
There was a problem hiding this comment.
We should store the time after we run the transaction.
|
@imtbkcat |
coocood
reviewed
Jun 28, 2019
meta/autoid/autoid.go
Outdated
| @@ -29,6 +30,12 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| const ( | |||
| minStep = 5000 | |||
There was a problem hiding this comment.
Can we make minStep lower like 1000?
There was a problem hiding this comment.
1000 is too small, let's say we want 200000 insert QPS in a single tidb server, how many transaction do we need? what if we met transaction conflict while updating the allocated meta.
There was a problem hiding this comment.
The minStep only matters when the insert QPS is very low.
coocood
reviewed
Jun 28, 2019
meta/autoid/autoid.go
Outdated
| } | ||
| }) | ||
|
|
||
| if consumeDur.Nanoseconds() == 0 { |
coocood
reviewed
Jun 28, 2019
meta/autoid/autoid.go
Outdated
| if consumeDur.Nanoseconds() == 0 { | ||
| return curStep | ||
| } | ||
| y := defaultComsumeTime.Seconds() / consumeDur.Seconds() |
jackysp
reviewed
Jun 28, 2019
ddl/db_test.go
Outdated
| @@ -2170,6 +2171,10 @@ func (s *testDBSuite4) TestComment(c *C) { | |||
| } | |||
|
|
|||
| func (s *testDBSuite5) TestRebaseAutoID(c *C) { | |||
There was a problem hiding this comment.
It is better to move them to the same suite.
|
LGTM |
added 13 commits
June 28, 2019 18:32
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/843 |
1 similar comment
|
/run-all-tests tidb-test=pr/843 |
alivxxx
reviewed
Jun 28, 2019
meta/autoid/autoid.go
Outdated
| const ( | ||
| minStep = 1000 | ||
| maxStep = 2000000 | ||
| defaultComsumeTime = 10 * time.Second |
added 2 commits
June 28, 2019 19:41
|
/run-all-tests tidb-test=pr/843 |
imtbkcat
added
status/all tests passed
status/LGT1
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Jul 1, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 1, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Jul 1, 2019
coocood
pushed a commit
that referenced
this pull request
Jul 1, 2019
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make auto increment id step can be adjust automatically according to auto id request speed.
What is changed and how it works?
add function
NextStepwhich can produce the next auto id step according to previous step.There are still many test need to be change, so do not merge.
Check List
Tests
Code changes
Side effects
Related changes