-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix oom action cancel bug #10993
Merged
Merged
*: fix oom action cancel bug #10993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10993 +/- ##
===========================================
Coverage 81.0758% 81.0758%
===========================================
Files 418 418
Lines 89473 89473
===========================================
Hits 72541 72541
Misses 11710 11710
Partials 5222 5222 |
Codecov Report
@@ Coverage Diff @@
## master #10993 +/- ##
================================================
- Coverage 81.1318% 80.9809% -0.1509%
================================================
Files 419 418 -1
Lines 90316 89237 -1079
================================================
- Hits 73275 72265 -1010
+ Misses 11784 11738 -46
+ Partials 5257 5234 -23 |
/run-all-tests |
@zz-jason @tiancaiamao PTAL |
zz-jason
reviewed
Jul 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
status/LGT1
Indicates that a PR has LGTM 1.
sig/execution
SIG execution
labels
Jul 1, 2019
LGTM |
tiancaiamao
approved these changes
Jul 1, 2019
needs to be cherry-picked to release-2.1 and release-3.0 |
zz-jason
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jul 1, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 1, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 1, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 1, 2019
winkyao
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/execution
SIG execution
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
set config.OOMAction = "cancel"
before this PR:
After This PR:
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes