types: add ToString method for HexLiteral and BitLiteral
#11029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2019 15:34
Codecov Report
@@ Coverage Diff @@
## master #11029 +/- ##
==============================================
- Coverage 81.1069% 80.961% -0.146%
==============================================
Files 419 418 -1
Lines 89615 89259 -356
==============================================
- Hits 72684 72265 -419
- Misses 11704 11757 +53
- Partials 5227 5237 +10 |
kennytm
reviewed
Jul 2, 2019
types/binary_literal.go
Outdated
| @@ -183,6 +183,11 @@ func NewBitLiteral(s string) (BitLiteral, error) { | |||
| return BitLiteral(b), nil | |||
| } | |||
|
|
|||
| // ToString implement ast.BinaryLiteral interface | |||
| func (b BitLiteral) ToString() string { | |||
| return string(b) | |||
There was a problem hiding this comment.
Suggested change
| return string(b) | |
| return BinaryLiteral(b).ToString() |
to ensure the implementations are the same.
types/binary_literal.go
Outdated
|
|
||
| // ToString implement ast.BinaryLiteral interface | ||
| func (b HexLiteral) ToString() string { | ||
| return string(b) |
There was a problem hiding this comment.
Suggested change
| return string(b) | |
| return BinaryLiteral(b).ToString() |
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
pingcap/parser#365 support hex and binary expression in
LOAD DATA.But import an new interface
ast.BinaryLiteralwhich requireHexLiteralandBinaryLiteralimplementToStringmethodWhat is changed and how it works?
add
ToStringmethod forHexLiteralandBitLiteralCheck List
Tests
Code changes
Side effects
Related changes