store/tikv: revert the optimization for optimistic conflicts pessimistic #11037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackysp PTAL |
Codecov Report
@@ Coverage Diff @@
## master #11037 +/- ##
================================================
- Coverage 81.4157% 80.9359% -0.4798%
================================================
Files 419 419
Lines 90598 89304 -1294
================================================
- Hits 73761 72279 -1482
- Misses 11644 11786 +142
- Partials 5193 5239 +46 |
|
/run-all-tests |
|
/run-common-test |
|
/run-unit-test |
|
/rebuild |
tiancaiamao
reviewed
Jul 3, 2019
session/pessimistic_test.go
Outdated
| syncCh <- struct{}{} | ||
| tk.MustQuery("select c from conflict where id = 1").Check(testkit.Rows("3")) | ||
|
|
||
| // Check utdated pessimistic lock is resolved. |
|
LGTM |
tiancaiamao
approved these changes
Jul 3, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The previous optimization return WriteConflict error when an optimistic transaction meets a pessimistic lock, this has the problem that optimistic transaction may reach retry limit soon and failed to resolve lock when pessimistic lock ttl is reached.
What is changed and how it works?
Revert the optimization.
Check List
Tests
Related changes