Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: make WindowFunction uncacheable in prepare (#11035) #11048

Merged
merged 2 commits into from
Jul 3, 2019
Merged

planner: make WindowFunction uncacheable in prepare (#11035) #11048

merged 2 commits into from
Jul 3, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 3, 2019

What problem does this PR solve?

cherry-pick #11035

@winoros winoros added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0 cherry-pick labels Jul 3, 2019
@winoros winoros requested review from alivxxx and lzmhhh123 July 3, 2019 03:18
alivxxx
alivxxx reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests tidb-test=release-3.0 tikv=release-3.0 pd=release-3.0

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2019
@tiancaiamao tiancaiamao mentioned this pull request Jul 3, 2019
Merged
zz-jason
zz-jason approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2019
@zz-jason zz-jason merged commit 3acb645 into pingcap:release-3.0 Jul 3, 2019
@winoros winoros deleted the pick-3.0 branch September 5, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winoros @tiancaiamao @zz-jason @alivxxx