-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: support dynamic enable/disable plugins #11122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11122 +/- ##
===========================================
Coverage 81.3541% 81.3541%
===========================================
Files 421 421
Lines 90948 90948
===========================================
Hits 73990 73990
Misses 11702 11702
Partials 5256 5256 |
plugin build CI will be fixed after https://github.com/pingcap/enterprise-plugin/pull/8 be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebuild |
What problem does this PR solve?
What is changed and how it works?
need use parser's new syntax pingcap/parser#374
then just change current disable flag and broadcast change via etcd
attention: we also need update plugins to let plugin's go.mod dep on new parser...
Check List
Tests
Code changes
Side effects
Related changes
This change is