Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type: add db prefix to function name for not exist error messages #11156

Merged
merged 8 commits into from
Sep 10, 2019
Merged

type: add db prefix to function name for not exist error messages #11156

merged 8 commits into from
Sep 10, 2019

Conversation

lizhenda
Copy link
Contributor

@lizhenda lizhenda commented Jul 10, 2019 •
edited by SunRunAway
Loading

What problem does this PR solve?

Close #11147

What is changed and how it works?

add db prefix to function name for not exist error messages

Check List

Tests

  • Unit test
  • Integration test

@winoros
Copy link
Member

winoros commented Jul 10, 2019

@lizhenda CI failed. Please take a look.

@lizhenda
Copy link
Contributor Author

@lizhenda CI failed. Please take a look.

OK

@lizhenda lizhenda changed the title Fix: add db prefix to function name for not exist error messages type: add db prefix to function name for not exist error messages Jul 13, 2019
@lizhenda
Copy link
Contributor Author

@winoros
CI success

SunRunAway
SunRunAway reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it is best to add a test in expression/integration_test.go

@SunRunAway
Copy link
Contributor

Friendly ping, @lizhenda

@zz-jason zz-jason added contribution This PR is from a community contributor. type/compatibility needs-cherry-pick-2.1 labels Jul 18, 2019
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #11156 into master will decrease coverage by 0.5638%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #11156        +/-   ##
================================================
- Coverage   81.8219%   81.2581%   -0.5639%     
================================================
  Files           423        423                
  Lines         92408      90167      -2241     
================================================
- Hits          75610      73268      -2342     
- Misses        11484      11592       +108     
+ Partials       5314       5307         -7

1 similar comment
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #11156 into master will decrease coverage by 0.5638%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #11156        +/-   ##
================================================
- Coverage   81.8219%   81.2581%   -0.5639%     
================================================
  Files           423        423                
  Lines         92408      90167      -2241     
================================================
- Hits          75610      73268      -2342     
- Misses        11484      11592       +108     
+ Partials       5314       5307         -7

@codecov
Copy link

codecov bot commented Jul 19, 2019 •
edited
Loading

Codecov Report

Merging #11156 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11156   +/-   ##
===========================================
  Coverage   81.5469%   81.5469%           
===========================================
  Files           450        450           
  Lines         96499      96499           
===========================================
  Hits          78692      78692           
  Misses        12222      12222           
  Partials       5585       5585

@lizhenda
Copy link
Contributor Author

@SunRunAway Done, please have a look.

SunRunAway
SunRunAway reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2019
@SunRunAway SunRunAway requested review from XuHuaiyu and winoros July 19, 2019 09:13
@SunRunAway
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason zz-jason requested a review from XuHuaiyu August 1, 2019 05:14
@XuHuaiyu XuHuaiyu removed their request for review August 1, 2019 08:42
@zz-jason zz-jason requested review from XuHuaiyu and removed request for winoros August 5, 2019 08:56
@zz-jason zz-jason removed the request for review from XuHuaiyu August 5, 2019 08:58
zz-jason
zz-jason approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 20, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 20, 2019

@lizhenda merge failed.

@lizhenda
Copy link
Contributor Author

@zz-jason integration-common-test failed

@zz-jason
Copy link
Member

/run-all-tests tidb-test=pr/888

1 similar comment
@zz-jason
Copy link
Member

/run-all-tests tidb-test=pr/888

@zz-jason
Copy link
Member

/run-common-test tidb-test=pr/888
/run-integration-common-test tidb-test=pr/888

@SunRunAway SunRunAway merged commit 5c18c5d into pingcap:master Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

cherry pick to release-2.1 failed

zz-jason pushed a commit to zz-jason/tidb that referenced this pull request Sep 10, 2019
@lizhenda @zz-jason
type: add db prefix to function name for not exist error messages (pi…
da49785 
…ngcap#11156)
@zz-jason zz-jason mentioned this pull request Sep 10, 2019
Merged
zz-jason pushed a commit to zz-jason/tidb that referenced this pull request Sep 10, 2019
@lizhenda @zz-jason
type: add db prefix to function name for not exist error messages (pi…
a7ca4c2 
…ngcap#11156)
@zz-jason zz-jason mentioned this pull request Sep 10, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @SunRunAway PTAL.

@SunRunAway
Copy link
Contributor

It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @SunRunAway PTAL.

It's already picked.

@lizhenda lizhenda deleted the add_db_to_func_not_exist_msg branch October 28, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@SunRunAway SunRunAway SunRunAway left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function information in error message should take along with database name
6 participants
@lizhenda @winoros @SunRunAway @sre-bot @zz-jason @XuHuaiyu