planner: some cleanup #11164
Merged
planner: some cleanup #11164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11164 +/- ##
=========================================
Coverage 81.463% 81.463%
=========================================
Files 423 423
Lines 91002 91002
=========================================
Hits 74133 74133
Misses 11523 11523
Partials 5346 5346 |
eurekaka
reviewed
Jul 11, 2019
| @@ -60,16 +59,16 @@ func (s *partitionProcessor) rewriteDataSource(lp LogicalPlan) (LogicalPlan, err | |||
| // Union->(UnionScan->DataSource1), (UnionScan->DataSource2) | |||
| children := make([]LogicalPlan, 0, len(ua.Children())) | |||
| for _, child := range ua.Children() { | |||
| us := LogicalUnionScan{}.Init(ua.ctx) | |||
| us := LogicalUnionScan{conditions: p.conditions}.Init(ua.ctx) | |||
There was a problem hiding this comment.
Is this line a bugfix? can we figure out a test case to cover it?
There was a problem hiding this comment.
Oh, another separate PR #11187 is working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Three cleanup.
What is changed and how it works?
Check List
Tests