executor/split: return split result when do split region and refine split timeout logic. #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11259 +/- ##
===========================================
Coverage 81.4875% 81.4875%
===========================================
Files 423 423
Lines 91020 91020
===========================================
Hits 74170 74170
Misses 11542 11542
Partials 5308 5308 |
bb7133
reviewed
Jul 15, 2019
Closed
bb7133
reviewed
Jul 22, 2019
executor/split.go
Outdated
| if err != nil { | ||
| if isCtxDone(ctxWithTimeout) { | ||
| // Do not break here for checking remain region scatter finished with a very short back off time. | ||
| // Imagine this situation, we split region 1,2,3, and timeout on wait region 1 scatter, |
There was a problem hiding this comment.
IMHO the comment is still not good enough... would you please get help from some other colleagues, like i18n team?
winkyao
reviewed
Jul 22, 2019
Co-Authored-By: bb7133 <bb7133@gmail.com>
Co-Authored-By: bb7133 <bb7133@gmail.com>
bb7133
reviewed
Jul 23, 2019
bb7133
approved these changes
Jul 23, 2019
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-cherry-picker |
2 similar comments
|
/run-cherry-picker |
|
/run-cherry-picker |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 29, 2019
…split timeout logic. (pingcap#11259)
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jul 29, 2019
…split timeout logic. (pingcap#11259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The old split region timeout logic was return error when timeout. But return error is not suitable. Because after TiDB send
splitandscatterrequest to PD, we should think the request must be executed successfully. The cost time ofsplitandscatterrequest finish depends on the TiKV/PD cluster whether busy.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes