-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: disallow dropping index on auto_increment column #11360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11360 +/- ##
================================================
- Coverage 81.5135% 81.2498% -0.2637%
================================================
Files 423 423
Lines 91045 90170 -875
================================================
- Hits 74214 73263 -951
- Misses 11541 11597 +56
- Partials 5290 5310 +20 |
Codecov Report
@@ Coverage Diff @@
## master #11360 +/- ##
================================================
- Coverage 81.3368% 81.2376% -0.0992%
================================================
Files 423 423
Lines 90392 90170 -222
================================================
- Hits 73522 73252 -270
- Misses 11577 11605 +28
- Partials 5293 5313 +20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
cherry pick to release-3.0 failed |
What problem does this PR solve?
TiDB:
MySQL 5.7:
What is changed and how it works?
When
DropIndex()
, checkAutoIncrement
flag in indexed columns.Check List
Tests
Related changes