Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add split-region-max-num in config to control the maximum split region number #11427

Merged
merged 6 commits into from
Jul 31, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

  • add split-region-max-num in config to control the maximum split region number.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #11427 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11427   +/-   ##
===========================================
  Coverage   81.4747%   81.4747%           
===========================================
  Files           425        425           
  Lines         92112      92112           
===========================================
  Hits          75048      75048           
  Misses        11708      11708           
  Partials       5356       5356

@crazycs520
Copy link
Contributor Author

@winkyao @bb7133 PTAL

config/config.toml.example Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/rebuild

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added needs-cherry-pick-2.1 status/LGT1 Indicates that a PR has LGTM 1. labels Jul 31, 2019
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

/run-all-tests

@sre-bot sre-bot merged commit d91ed2b into pingcap:master Jul 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

cherry pick to release-2.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2019

cherry pick to release-3.0 failed

crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 9, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 9, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Sep 9, 2019
sre-bot pushed a commit that referenced this pull request Sep 9, 2019
ngaut pushed a commit that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants