Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix delete error when convert string to float or int (#10861) #11471

Closed
wants to merge 3 commits into from
Closed

types: fix delete error when convert string to float or int (#10861) #11471

wants to merge 3 commits into from

Conversation

amyangfei
Copy link
Contributor

cherry-pick #10861 to release-3.0

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei mentioned this pull request Jul 26, 2019
Merged
@amyangfei
Copy link
Contributor Author

PTAL @zz-jason @qw4990

zz-jason
zz-jason reviewed Jul 27, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2019
@zz-jason zz-jason requested review from alivxxx and qw4990 July 27, 2019 02:00
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-unit-tests

SunRunAway
SunRunAway approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2019

@amyangfei merge failed.

@qw4990 qw4990 removed their request for review July 29, 2019 02:00
@amyangfei amyangfei closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@alivxxx alivxxx Awaiting requested review from alivxxx

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @sre-bot @SunRunAway @zz-jason