Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ConvertJSONToInt unsigned bug (#11483) #11551

Merged
merged 4 commits into from
Aug 5, 2019
Merged

fix ConvertJSONToInt unsigned bug (#11483) #11551

merged 4 commits into from
Aug 5, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 1, 2019

cherry-pick #11483 to release-3.0

H-ZeX added 2 commits August 1, 2019 10:49
@H-ZeX
fix StrToInt unsigned bug
225a8fb 
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@H-ZeX
change MustExec to MustQuery
1d8fc8a 
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 1, 2019
Merged
zz-jason
zz-jason reviewed Aug 3, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from qw4990 and SunRunAway August 3, 2019 08:22
@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Aug 3, 2019
SunRunAway
SunRunAway approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/PTAL status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 5, 2019

/run-all-tests

@qw4990 qw4990 removed their request for review August 5, 2019 07:16
@sre-bot sre-bot merged commit 2e0d32f into pingcap:release-3.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @SunRunAway @zz-jason @H-ZeX