executor, privileges: fix privilege check fail for CREATE USER and DROP USER
#11589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
sig/execution
tiancaiamao
reviewed
Aug 2, 2019
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #11589 +/- ##
===========================================
Coverage 81.7735% 81.7735%
===========================================
Files 435 435
Lines 94604 94604
===========================================
Hits 77361 77361
Misses 11798 11798
Partials 5445 5445 |
|
PTAL @lysu |
jackysp
added
the
status/can-merge
added 2 commits
August 19, 2019 14:04
|
/run-all-tests |
jackysp
approved these changes
Aug 19, 2019
jackysp
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Aug 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL. |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9111
What is changed and how it works?
This problem was caused by using
ctx.Execute(sql)to modify system privilege table. If user do not have privilege to insert or date tomysql.User, SQL execution will fail user hadCREATE USERprivilege.Using system session to execute sql to modify
mysql.Userwill fix this problem.Check List
Tests
Code changes
Side effects
Related changes