Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: update the minimum version of tikv information #11608

Merged
merged 6 commits into from
Aug 5, 2019
Merged

util: update the minimum version of tikv information #11608

merged 6 commits into from
Aug 5, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 5, 2019 •
edited
Loading

What problem does this PR solve?

update the minimum version of TiKV information to v3.0.0

What is changed and how it works?

Check List

Tests

  • No code

@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2019

Thanks for your PR.
This PR will be closed by bot because you already had 2 opened PRs, close or merge them before submitting a new one.
#11532 , #11561

@sre-bot sre-bot closed this Aug 5, 2019
@crazycs520 crazycs520 reopened this Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@829ba98). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11608   +/-   ##
===========================================
  Coverage          ?   81.2446%           
===========================================
  Files             ?        426           
  Lines             ?      92043           
  Branches          ?          0           
===========================================
  Hits              ?      74780           
  Misses            ?      11891           
  Partials          ?       5372

@crazycs520
Copy link
Contributor Author

/run-all-tests

winkyao
winkyao reviewed Aug 5, 2019
View reviewed changes
util/printer/printer.go Outdated Show resolved Hide resolved
zz-jason
zz-jason reviewed Aug 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2019
winkyao
winkyao reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao added needs-cherry-pick-3.0 status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit f0ba508 into pingcap:master Aug 5, 2019
@sre-bot sre-bot mentioned this pull request Aug 5, 2019
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2019

cherry pick to release-3.0 in PR #11618

sre-bot added a commit that referenced this pull request Aug 13, 2019
@sre-bot
util: update the minimum version of tikv information (#11608) (#11618)
66daa9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @sre-bot @zz-jason @winkyao