-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: remove the NotNullFlag for aggregation func MAX/MIN when inferring type (#11343) #11617
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zz-jason Robert didn't pick newest commit... |
What does |
@XuHuaiyu Commit #545bff7dced9862a297faf8d2f3d1e6067700b21 add following test case: tidb/expression/integration_test.go Line 2747 in 545bff7
and this PR pick the code as tidb/expression/integration_test.go Line 2757 in d9032e3
newest commit modify code like this: tidb/expression/integration_test.go Line 2747 in d5060fc
|
Hi @AndrewDi, |
Abandon this pr and use the traditional way |
cherry-pick #11343 to release-3.0
What problem does this PR solve?
Fix issue #11332
What is changed and how it works?
IF scalefunc is MAX or MIN, remove not null flag.
Check List
Tests