Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the NotNullFlag for aggregation func MAX/MIN when inferring type (#11343) #11617

Closed
wants to merge 9 commits into from

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 5, 2019

cherry-pick #11343 to release-3.0


What problem does this PR solve?

Fix issue #11332

What is changed and how it works?

IF scalefunc is MAX or MIN, remove not null flag.

Check List

Tests

  • Unit test

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 5, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Aug 5, 2019
@AndrewDi
Copy link
Contributor

AndrewDi commented Aug 5, 2019

@zz-jason Robert didn't pick newest commit...

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 5, 2019

What does newest commit mean?

@AndrewDi
Copy link
Contributor

AndrewDi commented Aug 5, 2019

@XuHuaiyu Commit #545bff7dced9862a297faf8d2f3d1e6067700b21 add following test case:

tk.MustExec("create table t1(a bigint not null")

and this PR pick the code as

tk.MustExec("create table t1(a bigint not null")

newest commit modify code like this:

tk.MustExec("create table t1(a bigint not null)")

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2019

CLA assistant check
All committers have signed the CLA.

@you06
Copy link
Contributor

you06 commented Aug 5, 2019

Hi @AndrewDi, update branch will submit some commits into PR's head branch, I'm afraid this makes the difference of your origin PR and this PR.

@SunRunAway
Copy link
Contributor

Abandon this pr and use the traditional way git cherry-pick 829ba98. See #11641

@SunRunAway SunRunAway closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants