*: rename tidb_back_off_weight #11655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
added
type/enhancement
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11655 +/- ##
================================================
- Coverage 81.4101% 81.2576% -0.1526%
================================================
Files 426 426
Lines 92513 92075 -438
================================================
- Hits 75315 74818 -497
- Misses 11826 11876 +50
- Partials 5372 5381 +9 |
|
LGTM |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
zimulala
reviewed
Aug 7, 2019
session/bootstrap.go
Outdated
| @@ -853,6 +858,10 @@ func upgradeToVer34(s Session) { | |||
| doReentrantDDL(s, CreateOptRuleBlacklist) | |||
| } | |||
|
|
|||
| func upgradeToVer35(s Session) { | |||
| mustExecute(s, "UPDATE HIGH_PRIORITY mysql.GLOBAL_VARIABLES SET VARIABLE_NAME='tidb_backoff_weight' WHERE VARIABLE_NAME='tidb_back_off_weight'") | |||
There was a problem hiding this comment.
Do we need to update other variables? If we need to, I think we'd better do it in the same PR. Then we can reduce versions.
There was a problem hiding this comment.
No other name needs to be changed.
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
/run-all-tests |
jackysp
added
status/LGT2
|
/run-all-tests |
|
@jackysp merge failed. |
|
/run-unit-test |
|
cherry pick to release-3.0 failed |
jackysp
added a commit
to jackysp/tidb
that referenced
this pull request
Aug 7, 2019
jackysp
added a commit
that referenced
this pull request
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
The
back_offintidb_back_off_weightis not consistent with the old variabletidb_backoff_lock_fast, which makes the user confused.What is changed and how it works?
It is a new variable, may not be used widely by users, so change it to
tidb_backoff_weight.Check List
Tests
Code changes
Side effects
Related changes