expression: fix a bug when comparing bit with string (#11654) #11659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11654 to release-2.1
What problem does this PR solve?
Issue: #11647
When a bit column compare with a constant string, it gets a wrong result.
Befor the pr:
This pr:
What is changed and how it works?
The reason is that we select a wrong target field type in function
RefineComparedConstant
.Before this pr, the target field is
TypeBit
, and convert '1' to 49.In fact, the target field shoule be an int type in this situation, and convert '1' to 1.
In this pr, I change the target field to
TypeLonglong
.Check List
Tests
Code changes
Side effects
Related changes