planner: rename optimizer hints #11673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreyes
force-pushed
the
dev/rename_optimizer_hints
branch
from
b832063
to
d668790
Compare
Codecov Report
@@ Coverage Diff @@
## master #11673 +/- ##
================================================
- Coverage 81.4841% 81.4003% -0.0838%
================================================
Files 433 433
Lines 93525 93190 -335
================================================
- Hits 76208 75857 -351
- Misses 11881 11890 +9
- Partials 5436 5443 +7 |
1 task
foreyes
changed the title
|
Idc fails because use |
|
PTAL. @lzmhhh123 @lamxTyler @XuHuaiyu |
|
/run-all-tests |
lzmhhh123
reviewed
Aug 12, 2019
foreyes
force-pushed
the
dev/rename_optimizer_hints
branch
from
e08391d
to
720d9d3
Compare
|
/run-all-tests |
foreyes
force-pushed
the
dev/rename_optimizer_hints
branch
from
27d96ce
to
f69753e
Compare
|
/run-all-tests |
|
The solution of |
|
Ready for review, PTAL. @lzmhhh123 |
lzmhhh123
reviewed
Aug 13, 2019
|
I think so, I will file an issue for it, like #11632 @lzmhhh123 Extract common warning message. |
|
PTAL again. Just change some warning messages. @lamxTyler |
|
/run-all-test |
|
/run-all-tests |
|
/run-ci-test |
lzmhhh123
approved these changes
Aug 14, 2019
lzmhhh123
added
status/all tests passed
status/can-merge
|
/run-all-tests |
|
@foreyes merge failed. |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support optimizer hint alias
HASH_JOIN: TIDB_HJ,SM_JOIN: TIDB_SMJ,INL_JOIN: TIDB_INLJ.Rename optimizer hints
TIDB_HASHAGG() -> HASH_AGG,TIDB_STREAMAGG() -> STREAM_AGG, and remove brackets.What is changed and how it works?
Add
HintHJ,HintSMJ,HintINLJhave the same effect asTIDBhints.We still keep TIDB style hints, for example,
TIDB_HJwill have the same HintName asHASH_JOINnow.Rename aggregation hints in parser and TiDB.
Check List
Tests
Code changes
Related changes