Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl : Fix generated column can refer only to generated columns defined prior to it. (#11549) #11682

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Aug 8, 2019

What problem does this PR solve?

cherry-pick to release2.1 #11549

What is changed and how it works?

Check List

keep using the old function, made a slight modification to origin PR.

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@AilinKid AilinKid changed the title Fix generated column can refer only to generated columns defined prior to it. Fix generated column can refer only to generated columns defined prior to it. (#11549) Aug 8, 2019
@Deardrops
Copy link
Contributor

LGTM

@AilinKid AilinKid added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Aug 8, 2019
@AilinKid AilinKid changed the title Fix generated column can refer only to generated columns defined prior to it. (#11549) ddl : Fix generated column can refer only to generated columns defined prior to it. (#11549) Aug 9, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit bb93c56 into pingcap:release-2.1 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants