expression: remove unnecessary convertIntToUint. fix error in err msg(should be bigint but not double)(#11640) #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
added
component/expression
type/2.1 cherry-pick
type/bugfix
XuHuaiyu
changed the title
|
LGTM |
ngaut
added
the
status/can-merge
|
/run-all-tests |
zz-jason
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11640 to release-2.1
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
In some of the code, we get a uint from the row which is stored in int, however, we needn't casting it from int to uint when it is uint, this will make some bugs.
In the origin
builtinCastStringAsDecimalSig::evalDecimal, the res is always not neg, this is a bug.What is changed and how it works?
Check List
Tests
Code changes
NO.
Side effects
NO.
Related changes